]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
resolved: add comment to dns_stream_complete() about its 'error' argument
authorLennart Poettering <lennart@poettering.net>
Mon, 21 Jan 2019 18:44:01 +0000 (19:44 +0100)
committerLennart Poettering <lennart@poettering.net>
Fri, 15 Feb 2019 16:13:58 +0000 (17:13 +0100)
src/resolve/resolved-dns-stream.c

index 45b06eb732e9b5b2891d326b510726121f96db65..3fd056bdb709e9879631f4ee5ac3a66b9c677559 100644 (file)
@@ -52,6 +52,10 @@ static int dns_stream_complete(DnsStream *s, int error) {
         _cleanup_(dns_stream_unrefp) _unused_ DnsStream *ref = dns_stream_ref(s); /* Protect stream while we process it */
 
         assert(s);
+        assert(error >= 0);
+
+        /* Error is > 0 when the connection failed for some reason in the network stack. It's == 0 if we sent
+         * and receieved exactly one packet each (in the LLMNR client case). */
 
 #if ENABLE_DNS_OVER_TLS
         if (s->encrypted) {