Fix 'Using uninitialized value' issue reported by Coverity.

* In a error code path, 'exitCode' variable is used without
  any initialization.  This issue was reported by the Coverity.
  Fixed it by initializing the 'exitCode' to -1.

* While fixing this, moved the variables to the if block where
  they are acutally used.

diff --git a/open-vm-tools/lib/procMgr/procMgrPosix.c b/open-vm-tools/lib/procMgr/procMgrPosix.c
index e2cd0619f0e22db2d1df7683c48221581da4a1d4..2f7711bdbdc02bc50882eb59a315fc2a24a28623 100644 (file)
--- a/open-vm-tools/lib/procMgr/procMgrPosix.c
+++ b/open-vm-tools/lib/procMgr/procMgrPosix.c
@@ -1638,8 +1638,6 @@ ProcMgr_ExecAsync(char const *cmd,                 // IN: UTF-8 command line
    ProcMgr_AsyncProc *asyncProc = NULL;
    pid_t pid;
    int fds[2];
-   Bool validExitCode = FALSE;
-   int exitCode;
    pid_t resultPid;
    int readFd, writeFd;
 
@@ -1664,6 +1662,8 @@ ProcMgr_ExecAsync(char const *cmd,                 // IN: UTF-8 command line
       int i, maxfd;
       Bool status = TRUE;
       pid_t childPid = -1;
+      Bool validExitCode = FALSE;
+      int exitCode = -1;
 
       /*
        * Child