]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
misc: ti_fpc202: remove dead code in fpc202_detach_addr()
authorFelix Gu <ustc.gu@gmail.com>
Fri, 20 Feb 2026 17:20:32 +0000 (01:20 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Apr 2026 14:29:20 +0000 (16:29 +0200)
val is assigned from addr_caches, which is a u8 array. So the check will
never be true.

Found by code review, compile pass.

Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: Romain Gantois <romain.gantois@bootlin.com>
Link: https://patch.msgid.link/20260221-fp202-v1-2-4d28cb8b28fb@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/ti_fpc202.c

index 578feefb77f1e2edbe3133254d7b9b3e761c07b3..79a029d79f7a6267a08959330f9dcefc755ad775 100644 (file)
@@ -243,23 +243,15 @@ static void fpc202_detach_addr(struct i2c_atr *atr, u32 chan_id,
                               u16 addr)
 {
        struct fpc202_priv *priv = i2c_atr_get_driver_data(atr);
-       int dev_num, reg_mod, val;
+       int dev_num, val;
 
        for (dev_num = 0; dev_num < 2; dev_num++) {
-               reg_mod = FPC202_REG_MOD_DEV(chan_id, dev_num);
-
                mutex_lock(&priv->reg_dev_lock);
 
                val = priv->addr_caches[chan_id][dev_num];
 
                mutex_unlock(&priv->reg_dev_lock);
 
-               if (val < 0) {
-                       dev_err(&priv->client->dev, "failed to read register 0x%x while detaching address 0x%02x\n",
-                               reg_mod, addr);
-                       return;
-               }
-
                if (val == (addr & 0x7f)) {
                        fpc202_write_dev_addr(priv, chan_id, dev_num, FPC202_REG_DEV_INVALID);
                        return;