]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
silence 'Dereference of undefined pointer value' by assigning to 'sorted' sequentiall...
authorMark Andrews <marka@isc.org>
Thu, 25 Aug 2011 06:28:11 +0000 (06:28 +0000)
committerMark Andrews <marka@isc.org>
Thu, 25 Aug 2011 06:28:11 +0000 (06:28 +0000)
lib/dns/rdataset.c

index e6fa634cd1a9989f3f04b1cc057b791f058eeacd..c17f661fcadaeb24e0cf9f2e04fe3143d4dfac79 100644 (file)
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: rdataset.c,v 1.90 2011/06/08 22:13:50 each Exp $ */
+/* $Id: rdataset.c,v 1.91 2011/08/25 06:28:11 marka Exp $ */
 
 /*! \file */
 
@@ -442,11 +442,11 @@ towiresorted(dns_rdataset_t *rdataset, const dns_name_t *owner_name,
                        j = val % count;
                        for (i = 0; i < count; i++) {
                                if (order != NULL)
-                                       sorted[j].key = (*order)(&shuffled[i],
+                                       sorted[i].key = (*order)(&shuffled[j],
                                                                 order_arg);
                                else
-                                       sorted[j].key = 0; /* Unused */
-                               sorted[j].rdata = &shuffled[i];
+                                       sorted[i].key = 0; /* Unused */
+                               sorted[i].rdata = &shuffled[j];
                                j++;
                                if (j == count)
                                        j = 0; /* Wrap around. */