]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core.git/commitdiff
quilt: fix dependency on ptest-runner
authorAwais Belal <awais.belal@gmail.com>
Tue, 12 Nov 2024 23:48:56 +0000 (04:48 +0500)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 14 Nov 2024 11:56:44 +0000 (11:56 +0000)
Specifically when using useradd-staticids this fails without
creating a ptest user entry.

ERROR: Nothing PROVIDES 'ptest-runner' ptest-runner was skipped: Recipe ptest-runner, package ptest-runner: system username "ptest" does not have a static ID defined. Add ptest to one of these files: .../passwd
...
...
Missing or unbuildable dependency chain was: ['my-image-sdk', 'packagegroup-core-sdk', 'quilt', 'ptest-runner']

This is seen when ptest is not even enabled. We fix this by
making a conditional dependency on the ptest-runner.

Signed-off-by: Awais B <awais.belal@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-devtools/quilt/quilt.inc

index 19aeae510d48f1131ea2075a76506b2a983ae4da..4bae5c6c1973a20b9fdf6702cd3b485a4b11c30f 100644 (file)
@@ -61,7 +61,7 @@ do_install:append:class-native () {
 
 # The tests need to run as a non-root user, so pull in the ptest user
 DEPENDS:append:class-target = "${@bb.utils.contains('PTEST_ENABLED', '1', ' ptest-runner', '', d)}"
-PACKAGE_WRITE_DEPS += "ptest-runner"
+PACKAGE_WRITE_DEPS += "${@bb.utils.contains('PTEST_ENABLED', '1', 'ptest-runner', '', d)}"
 
 do_install_ptest() {
        install ${UNPACKDIR}/test.sh ${D}${PTEST_PATH}