]> git.ipfire.org Git - thirdparty/ipxe.git/commitdiff
[fcp] Use EINVAL for URI parsing errors and EPROTO for protocol errors
authorMichael Brown <mcb30@ipxe.org>
Fri, 5 Nov 2010 04:09:29 +0000 (04:09 +0000)
committerMichael Brown <mcb30@ipxe.org>
Mon, 8 Nov 2010 03:35:36 +0000 (03:35 +0000)
Signed-off-by: Michael Brown <mcb30@ipxe.org>
src/net/fcp.c

index e413e0736c1a2945ed98fc07c3e65f3caa63d983..0da57cfcb59b4211e42e8ed82f7e92f8a30f2b05 100644 (file)
@@ -512,7 +512,7 @@ static int fcpcmd_recv_xfer_rdy ( struct fcp_command *fcpcmd,
                DBGC ( fcpdev, "FCP %p xchg %04x received invalid transfer "
                       "ready IU:\n", fcpdev, fcpcmd->xchg_id );
                DBGC_HDA ( fcpdev, 0, iobuf->data, iob_len ( iobuf ) );
-               rc = -EINVAL;
+               rc = -EPROTO;
                goto done;
        }
        if ( ntohl ( xfer_rdy->offset ) != fcpcmd->offset ) {
@@ -521,7 +521,7 @@ static int fcpcmd_recv_xfer_rdy ( struct fcp_command *fcpcmd,
                       "delivery (expected %zd, requested %d)\n",
                       fcpdev, fcpcmd->xchg_id, fcpcmd->offset,
                       ntohl ( xfer_rdy->offset ) );
-               rc = -EINVAL;
+               rc = -EPROTO;
                goto done;
        }
        DBGC2 ( fcpdev, "FCP %p xchg %04x XFER_RDY [%08x,%08x)\n",
@@ -564,7 +564,7 @@ static int fcpcmd_recv_rsp ( struct fcp_command *fcpcmd,
                DBGC ( fcpdev, "FCP %p xchg %04x received invalid response "
                       "IU:\n", fcpdev, fcpcmd->xchg_id );
                DBGC_HDA ( fcpdev, 0, iobuf->data, iob_len ( iobuf ) );
-               rc = -EINVAL;
+               rc = -EPROTO;
                goto done;
        }
        DBGC2 ( fcpdev, "FCP %p xchg %04x RSP stat %02x resid %08x flags %02x"
@@ -645,7 +645,7 @@ static int fcpcmd_recv_unknown ( struct fcp_command *fcpcmd,
               fcpdev, fcpcmd->xchg_id );
        DBGC_HDA ( fcpdev, 0, iobuf->data, iob_len ( iobuf ) );
        free_iob ( iobuf );
-       return -EINVAL;
+       return -EPROTO;
 }
 
 /**