]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: rtl8723bs: core/rtw_mlme_ext.c: flatten indentation with early loop continue...
authorWilliam Hansen-Baird <william.hansen.baird@gmail.com>
Tue, 13 Jan 2026 21:14:33 +0000 (16:14 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 16 Jan 2026 13:07:02 +0000 (14:07 +0100)
Replace large if (memcmp(p+2, WMM_IE, 6)) inside the for (;;) loop,
which ends with a break, with an early continue.
This reduces deep nesting and is purely stylistic.

Signed-off-by: William Hansen-Baird <william.hansen.baird@gmail.com>
Link: https://patch.msgid.link/20260113211433.89512-2-william.hansen.baird@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c

index ccb41922f727de2c04fdcab7c4d352d746a3657c..fa1e3ad592541e24597ace73085867e789348603 100644 (file)
@@ -1184,46 +1184,47 @@ unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_frame)
                        if (!p)
                                break;
 
-                       if (!memcmp(p+2, WMM_IE, 6)) {
+                       if (memcmp(p+2, WMM_IE, 6)) {
+                               p = p + ie_len + 2;
+                               continue;
+                       }
 
-                               pstat->flags |= WLAN_STA_WME;
+                       pstat->flags |= WLAN_STA_WME;
 
-                               pstat->qos_option = 1;
-                               pstat->qos_info = *(p+8);
+                       pstat->qos_option = 1;
+                       pstat->qos_info = *(p+8);
 
-                               pstat->max_sp_len = (pstat->qos_info>>5)&0x3;
+                       pstat->max_sp_len = (pstat->qos_info>>5)&0x3;
 
-                               if ((pstat->qos_info&0xf) != 0xf)
-                                       pstat->has_legacy_ac = true;
-                               else
-                                       pstat->has_legacy_ac = false;
-
-                               if (pstat->qos_info&0xf) {
-                                       if (pstat->qos_info&BIT(0))
-                                               pstat->uapsd_vo = BIT(0)|BIT(1);
-                                       else
-                                               pstat->uapsd_vo = 0;
+                       if ((pstat->qos_info&0xf) != 0xf)
+                               pstat->has_legacy_ac = true;
+                       else
+                               pstat->has_legacy_ac = false;
 
-                                       if (pstat->qos_info&BIT(1))
-                                               pstat->uapsd_vi = BIT(0)|BIT(1);
-                                       else
-                                               pstat->uapsd_vi = 0;
+                       if (pstat->qos_info&0xf) {
+                               if (pstat->qos_info&BIT(0))
+                                       pstat->uapsd_vo = BIT(0)|BIT(1);
+                               else
+                                       pstat->uapsd_vo = 0;
 
-                                       if (pstat->qos_info&BIT(2))
-                                               pstat->uapsd_bk = BIT(0)|BIT(1);
-                                       else
-                                               pstat->uapsd_bk = 0;
+                               if (pstat->qos_info&BIT(1))
+                                       pstat->uapsd_vi = BIT(0)|BIT(1);
+                               else
+                                       pstat->uapsd_vi = 0;
 
-                                       if (pstat->qos_info&BIT(3))
-                                               pstat->uapsd_be = BIT(0)|BIT(1);
-                                       else
-                                               pstat->uapsd_be = 0;
+                               if (pstat->qos_info&BIT(2))
+                                       pstat->uapsd_bk = BIT(0)|BIT(1);
+                               else
+                                       pstat->uapsd_bk = 0;
 
-                               }
+                               if (pstat->qos_info&BIT(3))
+                                       pstat->uapsd_be = BIT(0)|BIT(1);
+                               else
+                                       pstat->uapsd_be = 0;
 
-                               break;
                        }
-                       p = p + ie_len + 2;
+
+                       break;
                }
        }