]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
clk: xgene: Fix mapping leak in xgene_pllclk_init()
authorGeert Uytterhoeven <geert+renesas@glider.be>
Thu, 5 Mar 2026 10:11:16 +0000 (11:11 +0100)
committerStephen Boyd <sboyd@kernel.org>
Tue, 24 Mar 2026 00:19:27 +0000 (17:19 -0700)
If xgene_register_clk_pll() fails, the mapped register block is never
unmapped.

Fixes: 308964caeebc45eb ("clk: Add APM X-Gene SoC clock driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Brian Masney <bmasney@redhat.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/clk-xgene.c

index ba3b1057e4f0c61d1f1ba190c03797e711913b04..abb6c8fcdc91fad3dcf95dfcf9d5e14db395a817 100644 (file)
@@ -188,6 +188,8 @@ static void xgene_pllclk_init(struct device_node *np, enum xgene_pll_type pll_ty
                of_clk_add_provider(np, of_clk_src_simple_get, clk);
                clk_register_clkdev(clk, clk_name, NULL);
                pr_debug("Add %s clock PLL\n", clk_name);
+       } else {
+               iounmap(reg);
        }
 }