]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: davicom: Fix regulator not turned off on failed probe
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 11 Apr 2021 09:02:08 +0000 (11:02 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Apr 2021 10:05:46 +0000 (12:05 +0200)
commit 31457db3750c0b0ed229d836f2609fdb8a5b790e upstream.

When the probe fails, we must disable the regulator that was previously
enabled.

This patch is a follow-up to commit ac88c531a5b3
("net: davicom: Fix regulator not turned off on failed probe") which missed
one case.

Fixes: 7994fe55a4a2 ("dm9000: Add regulator and reset support to dm9000")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/davicom/dm9000.c

index ab06cf36af08340787910c1e3a33e131cc80904d..b8d82f32b2dbd3aa8e41050650cd74d2dbfcce35 100644 (file)
@@ -1484,8 +1484,10 @@ dm9000_probe(struct platform_device *pdev)
 
        /* Init network device */
        ndev = alloc_etherdev(sizeof(struct board_info));
-       if (!ndev)
-               return -ENOMEM;
+       if (!ndev) {
+               ret = -ENOMEM;
+               goto out_regulator_disable;
+       }
 
        SET_NETDEV_DEV(ndev, &pdev->dev);