watchdog: rz: Discard pm_runtime_put() return values

Failing a watchdog stop due to pm_runtime_put() returning a negative
value is not particularly useful.

Returning an error code from pm_runtime_put() merely means that it has
not queued up a work item to check whether or not the device can be
suspended and there are many perfectly valid situations in which that
can happen, like after writing "on" to the devices' runtime PM "control"
attribute in sysfs for one example.  It also happens when the kernel is
configured with CONFIG_PM unset.

Accordingly, update rzg2l_wdt_stop() and rzv2h_wdt_stop() to simply
discard the return value of pm_runtime_put().

This will facilitate a planned change of the pm_runtime_put() return
type to void in the future.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://patch.msgid.link/3340071.5fSG56mABF@rafael.j.wysocki

diff --git a/drivers/watchdog/rzg2l_wdt.c b/drivers/watchdog/rzg2l_wdt.c
index 1c9aa366d0a0ece84b1a5f4222eff3af29509e77..509f9dffdacde845c6c45b01d9da8d083f3de48c 100644 (file)
--- a/drivers/watchdog/rzg2l_wdt.c
+++ b/drivers/watchdog/rzg2l_wdt.c
@@ -132,9 +132,7 @@ static int rzg2l_wdt_stop(struct watchdog_device *wdev)
        if (ret)
                return ret;
 
-       ret = pm_runtime_put(wdev->parent);
-       if (ret < 0)
-               return ret;
+       pm_runtime_put(wdev->parent);
 
        return 0;
 }

diff --git a/drivers/watchdog/rzv2h_wdt.c b/drivers/watchdog/rzv2h_wdt.c
index a694786837e1140b0e2e4144c598425460b3a6a9..f93647934db74b7bb847b7d122e9df63d012f537 100644 (file)
--- a/drivers/watchdog/rzv2h_wdt.c
+++ b/drivers/watchdog/rzv2h_wdt.c
@@ -174,9 +174,7 @@ static int rzv2h_wdt_stop(struct watchdog_device *wdev)
        if (priv->of_data->wdtdcr)
                rzt2h_wdt_wdtdcr_count_stop(priv);
 
-       ret = pm_runtime_put(wdev->parent);
-       if (ret < 0)
-               return ret;
+       pm_runtime_put(wdev->parent);
 
        return 0;
 }