libcli/smb: Fix CID #710784 Resource leak

buf was (re-)allocated on NULL context thus not part of frame that is
freed.

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

diff --git a/libcli/smb/util.c b/libcli/smb/util.c
index 297d463626ccdf21ed8d4babb11700e0b9e66f4d..c42b21a6fb9f0d1c1589b1213a363382c372728d 100644 (file)
--- a/libcli/smb/util.c
+++ b/libcli/smb/util.c
@@ -267,6 +267,7 @@ static uint8_t *internal_bytes_push_str(uint8_t *buf, bool ucs2,
                                   ucs2 ? CH_UTF16LE : CH_DOS,
                                   str, str_len, &converted,
                                   &converted_size)) {
+               TALLOC_FREE(buf);
                TALLOC_FREE(frame);
                return NULL;
        }