hostapd: ucode: force restart on unresolvable static BSSID conflict

The guard meant to bail to a full restart read `!mac_idx < 0`, which parses
as `(!mac_idx) < 0` and is always false, so a static BSSID colliding with
the first (or a foreign-owned) BSS fell through and reassigned the wrong
BSS's address. Use `mac_idx <= 0`.

Signed-off-by: Felix Fietkau <nbd@nbd.name>

diff --git a/package/network/services/hostapd/files/hostapd.uc b/package/network/services/hostapd/files/hostapd.uc
index 4b85fd28637ea324e69750b1f04b5acecb295258..98e8dc9f8403caf498ca8db1b7bfbfac2dc6f6db 100644 (file)
--- a/package/network/services/hostapd/files/hostapd.uc
+++ b/package/network/services/hostapd/files/hostapd.uc
@@ -859,7 +859,7 @@ function iface_reload_config(name, phydev, config, old_config)
                // with the bssid of a reused interface. reassign the reused interface
                if (!bsscfg.default_macaddr) {
                        // can't update bssid of the first BSS, need to restart
-                       if (!mac_idx < 0)
+                       if (mac_idx <= 0)
                                return false;
 
                        bsscfg = config.bss[mac_idx];