]> git.ipfire.org Git - thirdparty/iproute2.git/commitdiff
iplink_geneve: correct size of message to avoid spurious errors
authorJakub Kicinski <jakub.kicinski@netronome.com>
Wed, 18 Apr 2018 18:06:07 +0000 (11:06 -0700)
committerStephen Hemminger <stephen@networkplumber.org>
Fri, 20 Apr 2018 17:39:53 +0000 (10:39 -0700)
Commit 6c4b672738ac ("iplink_geneve: Get rid of inet_get_addr()")
inadvertently changed the parameter to addattr_l() resulting in:

addattr_l ERROR: message exceeded bound of 4

when remote is specified.

Fixes: 6c4b672738ac ("iplink_geneve: Get rid of inet_get_addr()")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>
ip/iplink_geneve.c

index 1fcdd83acca92e9df8b4859f04977da2d9a918ed..26e70ff4db42de8802befa72d0fda41db98d29be 100644 (file)
@@ -199,7 +199,7 @@ static int geneve_parse_opt(struct link_util *lu, int argc, char **argv,
        if (is_addrtype_inet(&daddr)) {
                int type = (daddr.family == AF_INET) ? IFLA_GENEVE_REMOTE :
                                                       IFLA_GENEVE_REMOTE6;
-               addattr_l(n, sizeof(1024), type, daddr.data, daddr.bytelen);
+               addattr_l(n, 1024, type, daddr.data, daddr.bytelen);
        }
        if (!set_op || GENEVE_ATTRSET(attrs, IFLA_GENEVE_LABEL))
                addattr32(n, 1024, IFLA_GENEVE_LABEL, label);