]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
domain_conf: make virDomainGraphicsDefParseXMLEGLHeadless() void
authorMatt Coleman <mcoleman@datto.com>
Fri, 6 Nov 2020 03:32:43 +0000 (22:32 -0500)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 11 Nov 2020 11:53:11 +0000 (12:53 +0100)
This function always returns zero, so it might as well be void.

Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/conf/domain_conf.c

index 0233fd7607526558ab25e05dd507107cbf76ee06..bb65b6d0976f0b42a816d35cec6b87b43c70696e 100644 (file)
@@ -14883,7 +14883,7 @@ virDomainGraphicsDefParseXMLSpice(virDomainGraphicsDefPtr def,
 }
 
 
-static int
+static void
 virDomainGraphicsDefParseXMLEGLHeadless(virDomainGraphicsDefPtr def,
                                         xmlNodePtr node,
                                         xmlXPathContextPtr ctxt)
@@ -14896,7 +14896,6 @@ virDomainGraphicsDefParseXMLEGLHeadless(virDomainGraphicsDefPtr def,
     if ((glNode = virXPathNode("./gl", ctxt)))
         def->data.egl_headless.rendernode = virXMLPropString(glNode,
                                                              "rendernode");
-    return 0;
 }
 
 
@@ -14984,8 +14983,7 @@ virDomainGraphicsDefParseXML(virDomainXMLOptionPtr xmlopt,
             goto error;
         break;
     case VIR_DOMAIN_GRAPHICS_TYPE_EGL_HEADLESS:
-        if (virDomainGraphicsDefParseXMLEGLHeadless(def, node, ctxt) < 0)
-            goto error;
+        virDomainGraphicsDefParseXMLEGLHeadless(def, node, ctxt);
         break;
     case VIR_DOMAIN_GRAPHICS_TYPE_LAST:
         break;