Bluetooth: hci_conn: Use kmemdup() to replace kzalloc + memcpy

[ Upstream commit 5b6d345d1b65d67624349e5de22227492c637576 ]

Use kmemdup rather than duplicating its implementation.

./net/bluetooth/hci_conn.c:1880:7-14: WARNING opportunity for kmemdup.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5597
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Stable-dep-of: a09128921820 ("Bluetooth: hci_conn: Fix hci_le_set_cig_params")
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index ee9d6ff75246f59c0eb09ce503131bbf0575dfbc..7516166652a08c1c3a3ac01f180cd5df57cf2135 100644 (file)
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -1886,12 +1886,10 @@ static bool hci_le_set_cig_params(struct hci_conn *conn, struct bt_iso_qos *qos)
        if (qos->ucast.cis == BT_ISO_QOS_CIS_UNSET || !data.pdu.cp.num_cis)
                return false;
 
-       pdu = kzalloc(sizeof(*pdu), GFP_KERNEL);
+       pdu = kmemdup(&data.pdu, sizeof(*pdu), GFP_KERNEL);
        if (!pdu)
                return false;
 
-       memcpy(pdu, &data.pdu, sizeof(*pdu));
-
        if (hci_cmd_sync_queue(hdev, set_cig_params_sync, pdu,
                               set_cig_params_complete) < 0) {
                kfree(pdu);