]> git.ipfire.org Git - thirdparty/knot-resolver.git/commitdiff
typing: fixed types after type-checker update
authorVasek Sraier <git@vakabus.cz>
Mon, 24 May 2021 09:44:42 +0000 (11:44 +0200)
committerAleš Mrázek <ales.mrazek@nic.cz>
Fri, 8 Apr 2022 14:17:52 +0000 (16:17 +0200)
manager/knot_resolver_manager/kresd_controller/supervisord/__init__.py
manager/knot_resolver_manager/kresd_controller/supervisord/config.py
manager/knot_resolver_manager/utils/dataclasses_parservalidator.py

index d9d8752ba7f61dd032723afd9d42654f3da0bdc9..bc66133cc485746ba1f888a706db47c61d59e4e7 100644 (file)
@@ -17,7 +17,8 @@ logger = logging.getLogger(__name__)
 
 
 class SupervisordKresdController(BaseKresdController):
-    _config = SupervisordConfig([])
+    # ignore the type issue bellow. It's valid, but the type-checker does not understand dataclasses
+    _config = SupervisordConfig(instances=[])  # type: ignore
 
     async def is_running(self) -> bool:
         return self.id in SupervisordKresdController._config.instances
index 9a22aef1a69bfd66f1a35853bda21fa8dd8be0e2..408234ff2737cdb87e4f89983d2ceffc2f1aa2fa 100644 (file)
@@ -12,7 +12,7 @@ from knot_resolver_manager.utils.async_utils import call, readfile, wait_for_pro
 
 CONFIG_FILE = "/tmp/knot-resolver-manager-supervisord.conf"
 PID_FILE = "/tmp/knot-resolver-manager-supervisord.pid"
-SERVER_SOCK = "/tmp/knot-resolver-manager-supervisord.sock"  # created pseudorandomly from ASCII codes for K.R.M:SU
+SERVER_SOCK = "/tmp/knot-resolver-manager-supervisord.sock"
 
 
 @dataclass
index 3226f0f9503d1b9d1a0e874d3c1e1ed6e3d9f3cc..ab625688206d11458df1a5b5588402bc0968416b 100644 (file)
@@ -189,6 +189,12 @@ _T = TypeVar("_T", bound="DataclassParserValidatorMixin")
 
 
 class DataclassParserValidatorMixin:
+    def __init__(self, *args: Any, **kwargs: Any):
+        """
+        This constructor is useless except for typechecking. It makes sure that the dataclasses can be created with
+        any arguments whatsoever.
+        """
+
     def validate(self) -> None:
         for field_name in dir(self):
             # skip internal fields