]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
auth: Simplify is_our_machine_account()
authorVolker Lendecke <vl@samba.org>
Sun, 5 Sep 2021 06:59:13 +0000 (08:59 +0200)
committerJeremy Allison <jra@samba.org>
Tue, 7 Sep 2021 18:26:33 +0000 (18:26 +0000)
Use strnequal instead of duplicating a string

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/auth/server_info_sam.c

index 79a7af7281e592c5eec7495a6070d54efcae93c1..b9c8b0a0959093eadd783c400d52c210094fbbb4 100644 (file)
 static bool is_our_machine_account(const char *username)
 {
        bool ret;
-       char *truncname = NULL;
        size_t ulen = strlen(username);
 
        if (ulen == 0 || username[ulen-1] != '$') {
                return false;
        }
-       truncname = SMB_STRDUP(username);
-       if (!truncname) {
-               return false;
-       }
-       truncname[ulen-1] = '\0';
-       ret = strequal(truncname, lp_netbios_name());
-       SAFE_FREE(truncname);
+       ret = strnequal(username, lp_netbios_name(), ulen-1);
        return ret;
 }