]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
remoteproc: ti_k3_r5: Simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 11 Oct 2024 13:09:12 +0000 (15:09 +0200)
committerMathieu Poirier <mathieu.poirier@linaro.org>
Tue, 15 Oct 2024 17:42:59 +0000 (11:42 -0600)
Use scoped for_each_available_child_of_node_scoped() when iterating over
device nodes to make code a bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20241011-remote-proc-dev-err-probe-v1-4-5abb4fc61eca@linaro.org
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
drivers/remoteproc/ti_k3_r5_remoteproc.c

index 5a2e0464e1b81e3d4571a466643f08a53ebefc0d..2f996a962f55755347e599551f8b7785b986d0dd 100644 (file)
@@ -1650,16 +1650,14 @@ static int k3_r5_cluster_of_init(struct platform_device *pdev)
        struct device *dev = &pdev->dev;
        struct device_node *np = dev_of_node(dev);
        struct platform_device *cpdev;
-       struct device_node *child;
        struct k3_r5_core *core;
        int ret;
 
-       for_each_available_child_of_node(np, child) {
+       for_each_available_child_of_node_scoped(np, child) {
                cpdev = of_find_device_by_node(child);
                if (!cpdev) {
                        ret = -ENODEV;
                        dev_err(dev, "could not get R5 core platform device\n");
-                       of_node_put(child);
                        goto fail;
                }
 
@@ -1668,7 +1666,6 @@ static int k3_r5_cluster_of_init(struct platform_device *pdev)
                        dev_err(dev, "k3_r5_core_of_init failed, ret = %d\n",
                                ret);
                        put_device(&cpdev->dev);
-                       of_node_put(child);
                        goto fail;
                }