]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
KVM: s390: Replace sprintf with snprintf for buffer safety
authorJosephine Pfeiffer <hi@josie.lol>
Wed, 1 Oct 2025 17:40:46 +0000 (19:40 +0200)
committerJanosch Frank <frankja@linux.ibm.com>
Mon, 20 Oct 2025 12:43:18 +0000 (12:43 +0000)
Replace sprintf() with snprintf() when formatting debug names to prevent
potential buffer overflow. The debug_name buffer is 16 bytes, and while
unlikely to overflow with current PIDs, using snprintf() provides proper
bounds checking.

Signed-off-by: Josephine Pfeiffer <hi@josie.lol>
[frankja@linux.ibm.com: Fixed subject prefix]
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
arch/s390/kvm/kvm-s390.c

index 677aa5c7d226bd86917c00f440eb69ad1cf98751..70ebc54b1bb1133ed46ada1e33a6aebbbce9467b 100644 (file)
@@ -3348,7 +3348,7 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type)
        if (!kvm->arch.sca)
                goto out_err;
 
-       sprintf(debug_name, "kvm-%u", current->pid);
+       snprintf(debug_name, sizeof(debug_name), "kvm-%u", current->pid);
 
        kvm->arch.dbf = debug_register(debug_name, 32, 1, 7 * sizeof(long));
        if (!kvm->arch.dbf)