lib-program-client: Change return type of program_client_connected() to void.

Returning an int status code is no longer useful.

diff --git a/src/lib-program-client/program-client-local.c b/src/lib-program-client/program-client-local.c
index f82bd468494a912fff342feda020531ec72b245b..8d7ac57aeae2339254535aa2ed0a71fda24bdb1d 100644 (file)
--- a/src/lib-program-client/program-client-local.c
+++ b/src/lib-program-client/program-client-local.c
@@ -273,7 +273,8 @@ program_client_local_connect(struct program_client *pclient)
                child_wait_new_with_pid(plclient->pid,
                                        program_client_local_waitchild,
                                        plclient);
-       return program_client_connected(pclient);
+       program_client_connected(pclient);
+       return 0;
 }
 
 static int

diff --git a/src/lib-program-client/program-client-private.h b/src/lib-program-client/program-client-private.h
index 9873c33286a8703f215474159d31018a9f9e7a00..d2f6806fbcf8867b7724570ce2cf61a59d6c48fd 100644 (file)
--- a/src/lib-program-client/program-client-private.h
+++ b/src/lib-program-client/program-client-private.h
@@ -74,7 +74,7 @@ void program_client_init(struct program_client *pclient, pool_t pool,
 
 void program_client_init_streams(struct program_client *pclient);
 
-int program_client_connected(struct program_client *pclient);
+void program_client_connected(struct program_client *pclient);
 
 void program_client_fail(struct program_client *pclient,
                         enum program_client_error error);

diff --git a/src/lib-program-client/program-client-remote.c b/src/lib-program-client/program-client-remote.c
index e0dd99e43b369f13ccd36471dbcfe21833122b6f..16468b97de5df88a1fd7e069fd0cd10df076dd53 100644 (file)
--- a/src/lib-program-client/program-client-remote.c
+++ b/src/lib-program-client/program-client-remote.c
@@ -271,7 +271,7 @@ program_client_remote_connected(struct program_client_remote *prclient)
                return;
        }
 
-       (void)program_client_connected(pclient);
+       program_client_connected(pclient);
 }
 
 static int

diff --git a/src/lib-program-client/program-client.c b/src/lib-program-client/program-client.c
index d7d33c9a65e1b527c09933ae05ca6a8429b54d37..cdba6716dc4abbbfc5700a8f87af736ad6c3390e 100644 (file)
--- a/src/lib-program-client/program-client.c
+++ b/src/lib-program-client/program-client.c
@@ -350,10 +350,8 @@ program_client_extra_fd_input(struct program_client_extra_fd *efd)
        }
 }
 
-int program_client_connected(struct program_client *pclient)
+void program_client_connected(struct program_client *pclient)
 {
-       int ret = 1;
-
        /* finish creating program input */
        if (pclient->raw_program_input != NULL) {
                struct istream *input = pclient->raw_program_input;
@@ -400,8 +398,6 @@ int program_client_connected(struct program_client *pclient)
                        program_client_output_pump_finished, pclient);
                iostream_pump_start(pclient->pump_out);
        }
-
-       return ret;
 }
 
 void program_client_init(struct program_client *pclient, pool_t pool,