crypto: qce - Provide dev_err_probe() status on DMA failure

On multiple occasions the qce device have shown up in devices_deferred,
without the explanation that this came from the failure to acquire the
DMA channels from the associated BAM.

Use dev_err_probe() to associate this context with the failure to faster
pinpoint the culprit when this happens in the future.

Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
Reviewed-by: David Heidelberg <david@ixit.cz>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/qce/dma.c b/drivers/crypto/qce/dma.c
index 1dec7aea852dd91e4b2406f5418c0f533731b8fc..68cafd4741ad3d91906d39e817fc7873b028d498 100644 (file)
--- a/drivers/crypto/qce/dma.c
+++ b/drivers/crypto/qce/dma.c
@@ -24,11 +24,13 @@ int devm_qce_dma_request(struct device *dev, struct qce_dma_data *dma)
 
        dma->txchan = dma_request_chan(dev, "tx");
        if (IS_ERR(dma->txchan))
-               return PTR_ERR(dma->txchan);
+               return dev_err_probe(dev, PTR_ERR(dma->txchan),
+                                    "Failed to get TX DMA channel\n");
 
        dma->rxchan = dma_request_chan(dev, "rx");
        if (IS_ERR(dma->rxchan)) {
-               ret = PTR_ERR(dma->rxchan);
+               ret = dev_err_probe(dev, PTR_ERR(dma->rxchan),
+                                   "Failed to get RX DMA channel\n");
                goto error_rx;
        }