]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
can: rcar_canfd: Simplify data access in rcar_canfd_{ge,pu}t_data()
authorGeert Uytterhoeven <geert+renesas@glider.be>
Wed, 11 Jun 2025 15:37:34 +0000 (17:37 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Fri, 13 Jun 2025 07:34:08 +0000 (09:34 +0200)
Replace the repeated casts, pointer additions, and pointer dereferences
by array accesses to improve readability.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Link: https://patch.msgid.link/4f43f44dcfda13d48a2c502648833934a51d9d6c.1749655315.git.geert+renesas@glider.be
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/rcar/rcar_canfd.c

index 3244584a6ee5d67b71b6ecf81631b04a507e1a23..dded509793bb93ecac8d5aecc2cd864581b5d28f 100644 (file)
@@ -781,23 +781,23 @@ static void rcar_canfd_update_bit(void __iomem *base, u32 reg,
 static void rcar_canfd_get_data(struct rcar_canfd_channel *priv,
                                struct canfd_frame *cf, u32 off)
 {
+       u32 *data = (u32 *)cf->data;
        u32 i, lwords;
 
        lwords = DIV_ROUND_UP(cf->len, sizeof(u32));
        for (i = 0; i < lwords; i++)
-               *((u32 *)cf->data + i) =
-                       rcar_canfd_read(priv->base, off + i * sizeof(u32));
+               data[i] = rcar_canfd_read(priv->base, off + i * sizeof(u32));
 }
 
 static void rcar_canfd_put_data(struct rcar_canfd_channel *priv,
                                struct canfd_frame *cf, u32 off)
 {
+       const u32 *data = (u32 *)cf->data;
        u32 i, lwords;
 
        lwords = DIV_ROUND_UP(cf->len, sizeof(u32));
        for (i = 0; i < lwords; i++)
-               rcar_canfd_write(priv->base, off + i * sizeof(u32),
-                                *((u32 *)cf->data + i));
+               rcar_canfd_write(priv->base, off + i * sizeof(u32), data[i]);
 }
 
 static void rcar_canfd_tx_failure_cleanup(struct net_device *ndev)