Remove version warning in SQL Server

Remove warning for SQL Server dialect when a new version is detected.
The warning was originally added more than 15 years ago due to an unexpected
value returned when using an old version of FreeTDS.
The assumption is that since then the issue has been resolved, so make the
SQL Server dialect behave like the other ones that don't have an upper bound
check on the version number.

This effectively reverts 64d92c836ce029e33b57bcabd4ca76944549e022
that was added for #1825

Fixes: #13185
Change-Id: I79c6951b2fbb6da2caefca97dc3e1b9d8f48f0ab

diff --git a/doc/build/changelog/unreleased_20/13185.rst b/doc/build/changelog/unreleased_20/13185.rst
new file mode 100644 (file)
index 0000000..a4c1b20
--- /dev/null
+++ b/doc/build/changelog/unreleased_20/13185.rst
@@ -0,0 +1,10 @@
+.. change::
+    :tags: mssql, usecase
+    :tickets: 13185
+
+    Remove warning for SQL Server dialect when a new version is detected.
+    The warning was originally added more than 15 years ago due to an unexpected
+    value returned when using an old version of FreeTDS.
+    The assumption is that since then the issue has been resolved, so make the
+    SQL Server dialect behave like the other ones that don't have an upper bound
+    check on the version number.

diff --git a/lib/sqlalchemy/dialects/mssql/base.py b/lib/sqlalchemy/dialects/mssql/base.py
index eae3fe7058ae74e73dc89aa8080abac9ff7802d4..b8fdab4feac30fa3c26c75cfde8d8235d244c872 100644 (file)
--- a/lib/sqlalchemy/dialects/mssql/base.py
+++ b/lib/sqlalchemy/dialects/mssql/base.py
@@ -3306,13 +3306,6 @@ class MSDialect(default.DefaultDialect):
         self._setup_supports_comments(connection)
 
     def _setup_version_attributes(self):
-        if self.server_version_info[0] not in list(range(8, 17)):
-            util.warn(
-                "Unrecognized server version info '%s'.  Some SQL Server "
-                "features may not function properly."
-                % ".".join(str(x) for x in self.server_version_info)
-            )
-
         if self.server_version_info >= MS_2008_VERSION:
             self.supports_multivalues_insert = True
         else:

diff --git a/test/dialect/mssql/test_engine.py b/test/dialect/mssql/test_engine.py
index 8703cae765e15e2d695b7857f5efd701f508021c..1a8d27fb1f1a8a32628c815aaee7b97f6c9a0189 100644 (file)
--- a/test/dialect/mssql/test_engine.py
+++ b/test/dialect/mssql/test_engine.py
@@ -424,18 +424,6 @@ class ParseConnectTest(fixtures.TestBase):
             False,
         )
 
-    @testing.requires.mssql_freetds
-    def test_bad_freetds_warning(self):
-        engine = engines.testing_engine()
-
-        def _bad_version(connection):
-            return 95, 10, 255
-
-        engine.dialect._get_server_version_info = _bad_version
-        assert_raises_message(
-            exc.SAWarning, "Unrecognized server version info", engine.connect
-        )
-
 
 class FastExecutemanyTest(fixtures.TestBase):
     __only_on__ = "mssql"