]> git.ipfire.org Git - thirdparty/freeswitch.git/commitdiff
fix possible bad pointer in global vars (please test)
authorAnthony Minessale <anthm@freeswitch.org>
Wed, 2 Feb 2011 22:22:43 +0000 (16:22 -0600)
committerAnthony Minessale <anthm@freeswitch.org>
Wed, 2 Feb 2011 22:22:43 +0000 (16:22 -0600)
fscomm/widgets/codecwidget.cpp

index 42b10febfd9ec569788f0262a3173972bbfd2a01..2f82e1a8ccaab45947b15fe829d9f694d7d5b32e 100644 (file)
@@ -131,6 +131,8 @@ void CodecWidget::setCodecString(QString codecList)
         QStringList parsed = codecList.split("{");
         QString var = parsed.at(1);
         var = var.split("}").at(0);
+               // warning switch_core_get_Variable may return an unsafe pointer in some cases.
+               // revise to use switch_core_get_variable_dup, and then free it after you are done.
         var = switch_core_get_variable(var.toAscii().data());
         if ( ! var.isEmpty() ) {
             codecList = var;