]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
dont test squelched warnings against the filter
authorMike Bayer <mike_mp@zzzcomputing.com>
Sun, 23 Jan 2022 14:28:22 +0000 (09:28 -0500)
committerMike Bayer <mike_mp@zzzcomputing.com>
Sun, 23 Jan 2022 14:28:22 +0000 (09:28 -0500)
I spent days on Ibcf09af25228d39ee5a943fda82d8a9302433726
reading it over and over again and noticed this slight inaccuracy
10 seconds after I merged it.

the assert_warns_message() and assert_warns() functions should
not consider a mismatched warning class as valid for a match.

Change-Id: Ib8944dd95bcec1a7e4963917a5f4829e2ba27732

lib/sqlalchemy/testing/assertions.py

index 2a00f1c140e2eb16b4ef219719b198c6eaa34534..5c79422dd1434a2dd27cf591c49391ca568d29ee 100644 (file)
@@ -187,6 +187,8 @@ def _expect_warnings(
             if not exception or not issubclass(exception, _EXC_CLS):
                 if not squelch_other_warnings:
                     return real_warn(msg, *arg, **kw)
+                else:
+                    return
 
             if not filters and not raise_on_any_unexpected:
                 return