]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
i2c: rtl9300: use of instead of fwnode
authorRosen Penev <rosenp@gmail.com>
Wed, 17 Dec 2025 06:30:27 +0000 (22:30 -0800)
committerAndi Shyti <andi.shyti@kernel.org>
Thu, 15 Jan 2026 17:30:27 +0000 (18:30 +0100)
Avoids having to use to_of_node and just assign directly. This is an OF
only driver anyway.

Use _scoped for the for each loop to avoid refcount leaks.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20251217063027.37987-3-rosenp@gmail.com
drivers/i2c/busses/i2c-rtl9300.c

index f2aa341a7cdd95c30cfcc9fecbc5acb2a542bc9a..672cb978066d6cc4d85ad93e0b1e0c2473e11d92 100644 (file)
@@ -371,7 +371,6 @@ static int rtl9300_i2c_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
        struct rtl9300_i2c *i2c;
-       struct fwnode_handle *child;
        const struct rtl9300_i2c_drv_data *drv_data;
        struct reg_field fields[F_NUM_FIELDS];
        u32 clock_freq, scl_num, sda_num;
@@ -415,15 +414,15 @@ static int rtl9300_i2c_probe(struct platform_device *pdev)
                return ret;
 
        i = 0;
-       device_for_each_child_node(dev, child) {
+       for_each_child_of_node_scoped(dev->of_node, child) {
                struct rtl9300_i2c_chan *chan = &i2c->chans[i];
                struct i2c_adapter *adap = &chan->adap;
 
-               ret = fwnode_property_read_u32(child, "reg", &sda_num);
+               ret = of_property_read_u32(child, "reg", &sda_num);
                if (ret)
                        return ret;
 
-               ret = fwnode_property_read_u32(child, "clock-frequency", &clock_freq);
+               ret = of_property_read_u32(child, "clock-frequency", &clock_freq);
                if (ret)
                        clock_freq = I2C_MAX_STANDARD_MODE_FREQ;
 
@@ -449,7 +448,7 @@ static int rtl9300_i2c_probe(struct platform_device *pdev)
                adap->retries = 3;
                adap->dev.parent = dev;
                i2c_set_adapdata(adap, chan);
-               adap->dev.of_node = to_of_node(child);
+               adap->dev.of_node = child;
                snprintf(adap->name, sizeof(adap->name), "%s SDA%d\n", dev_name(dev), sda_num);
                i++;