]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuDomainGetStatsCpuHaltPollTime: Remove return value
authorPeter Krempa <pkrempa@redhat.com>
Mon, 17 Feb 2025 12:51:10 +0000 (13:51 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 20 Feb 2025 14:15:40 +0000 (15:15 +0100)
The function can't fail. Remove return value and refactor callers.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_driver.c

index a93899ceb580f06c60a8aa93e30e2b8cb1ef1c0c..e2db449a7a4e5bc3ba797e7b62534d910f323f92 100644 (file)
@@ -16920,7 +16920,7 @@ qemuDomainGetStatsCpuHaltPollTimeFromStats(virDomainObj *dom,
 }
 
 
-static int
+static void
 qemuDomainGetStatsCpuHaltPollTime(virDomainObj *dom,
                                   virTypedParamList *params,
                                   unsigned int privflags)
@@ -16929,17 +16929,17 @@ qemuDomainGetStatsCpuHaltPollTime(virDomainObj *dom,
     unsigned long long haltPollFail = 0;
 
     if (!virDomainObjIsActive(dom))
-        return 0;
+        return;
 
     if (qemuDomainGetStatsCpuHaltPollTimeFromStats(dom, privflags,
                                                    &haltPollSuccess, &haltPollFail) < 0 &&
         virHostCPUGetHaltPollTime(dom->pid, &haltPollSuccess, &haltPollFail) < 0)
-        return 0;
+        return;
 
     virTypedParamListAddULLong(params, haltPollSuccess, "cpu.haltpoll.success.time");
     virTypedParamListAddULLong(params, haltPollFail, "cpu.haltpoll.fail.time");
 
-    return 0;
+    return;
 }
 
 static int
@@ -16959,8 +16959,7 @@ qemuDomainGetStatsCpu(virQEMUDriver *driver,
     if (qemuDomainGetStatsCpuCache(driver, dom, params) < 0)
         return -1;
 
-    if (qemuDomainGetStatsCpuHaltPollTime(dom, params, privflags) < 0)
-        return -1;
+    qemuDomainGetStatsCpuHaltPollTime(dom, params, privflags);
 
     return 0;
 }