]> git.ipfire.org Git - thirdparty/fastapi/fastapi.git/commitdiff
✅ Simplify tests for `app_testing` (#13220)
authoralv2017 <v.alishauskaite@gmail.com>
Sat, 15 Feb 2025 14:42:41 +0000 (16:42 +0200)
committerGitHub <noreply@github.com>
Sat, 15 Feb 2025 14:42:41 +0000 (15:42 +0100)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Alejandra <90076947+alejsdev@users.noreply.github.com>
tests/test_tutorial/test_testing/test_main_b.py
tests/test_tutorial/test_testing/test_main_b_an.py [deleted file]
tests/test_tutorial/test_testing/test_main_b_an_py310.py [deleted file]
tests/test_tutorial/test_testing/test_main_b_an_py39.py [deleted file]
tests/test_tutorial/test_testing/test_main_b_py310.py [deleted file]

index 1e1836f5b362ed2c3a81e92ca96981f5a2ddee2b..aa7f969c6d612fca57ca0b59e74bbcbbeb5effbe 100644 (file)
@@ -1,7 +1,28 @@
-from docs_src.app_testing.app_b import test_main
+import importlib
+from types import ModuleType
 
+import pytest
 
-def test_app():
+from ...utils import needs_py39, needs_py310
+
+
+@pytest.fixture(
+    name="test_module",
+    params=[
+        "app_b.test_main",
+        pytest.param("app_b_py310.test_main", marks=needs_py310),
+        "app_b_an.test_main",
+        pytest.param("app_b_an_py39.test_main", marks=needs_py39),
+        pytest.param("app_b_an_py310.test_main", marks=needs_py310),
+    ],
+)
+def get_test_module(request: pytest.FixtureRequest) -> ModuleType:
+    mod: ModuleType = importlib.import_module(f"docs_src.app_testing.{request.param}")
+    return mod
+
+
+def test_app(test_module: ModuleType):
+    test_main = test_module
     test_main.test_create_existing_item()
     test_main.test_create_item()
     test_main.test_create_item_bad_token()
diff --git a/tests/test_tutorial/test_testing/test_main_b_an.py b/tests/test_tutorial/test_testing/test_main_b_an.py
deleted file mode 100644 (file)
index e53fc32..0000000
+++ /dev/null
@@ -1,10 +0,0 @@
-from docs_src.app_testing.app_b_an import test_main
-
-
-def test_app():
-    test_main.test_create_existing_item()
-    test_main.test_create_item()
-    test_main.test_create_item_bad_token()
-    test_main.test_read_nonexistent_item()
-    test_main.test_read_item()
-    test_main.test_read_item_bad_token()
diff --git a/tests/test_tutorial/test_testing/test_main_b_an_py310.py b/tests/test_tutorial/test_testing/test_main_b_an_py310.py
deleted file mode 100644 (file)
index c974e5d..0000000
+++ /dev/null
@@ -1,13 +0,0 @@
-from ...utils import needs_py310
-
-
-@needs_py310
-def test_app():
-    from docs_src.app_testing.app_b_an_py310 import test_main
-
-    test_main.test_create_existing_item()
-    test_main.test_create_item()
-    test_main.test_create_item_bad_token()
-    test_main.test_read_nonexistent_item()
-    test_main.test_read_item()
-    test_main.test_read_item_bad_token()
diff --git a/tests/test_tutorial/test_testing/test_main_b_an_py39.py b/tests/test_tutorial/test_testing/test_main_b_an_py39.py
deleted file mode 100644 (file)
index 71f9972..0000000
+++ /dev/null
@@ -1,13 +0,0 @@
-from ...utils import needs_py39
-
-
-@needs_py39
-def test_app():
-    from docs_src.app_testing.app_b_an_py39 import test_main
-
-    test_main.test_create_existing_item()
-    test_main.test_create_item()
-    test_main.test_create_item_bad_token()
-    test_main.test_read_nonexistent_item()
-    test_main.test_read_item()
-    test_main.test_read_item_bad_token()
diff --git a/tests/test_tutorial/test_testing/test_main_b_py310.py b/tests/test_tutorial/test_testing/test_main_b_py310.py
deleted file mode 100644 (file)
index e30cdc0..0000000
+++ /dev/null
@@ -1,13 +0,0 @@
-from ...utils import needs_py310
-
-
-@needs_py310
-def test_app():
-    from docs_src.app_testing.app_b_py310 import test_main
-
-    test_main.test_create_existing_item()
-    test_main.test_create_item()
-    test_main.test_create_item_bad_token()
-    test_main.test_read_nonexistent_item()
-    test_main.test_read_item()
-    test_main.test_read_item_bad_token()