conf: cpu: Remove NULL check from virCPUDefCopy

Make all callers always pass a valid pointer which in turn allows us to
remove return value check from the callers.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>

diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c
index 3b824e85d2ef464299ebd2d3b04936f43cdaba2b..9f5e8cb8485da583b45d27ead410906f77d4abdb 100644 (file)
--- a/src/conf/cpu_conf.c
+++ b/src/conf/cpu_conf.c
@@ -271,12 +271,7 @@ virCPUDefCopyWithoutModel(const virCPUDef *cpu)
 virCPUDef *
 virCPUDefCopy(const virCPUDef *cpu)
 {
-    g_autoptr(virCPUDef) copy = NULL;
-
-    if (!cpu)
-        return NULL;
-
-    copy = virCPUDefCopyWithoutModel(cpu);
+    g_autoptr(virCPUDef) copy = virCPUDefCopyWithoutModel(cpu);
 
     virCPUDefCopyModel(copy, cpu, false);
 

diff --git a/src/conf/cpu_conf.h b/src/conf/cpu_conf.h
index 560b59777706b46d8f4381f648219c68509b2dbd..82083d668cf14b4d301e3cf12fecb0738e66efa1 100644 (file)
--- a/src/conf/cpu_conf.h
+++ b/src/conf/cpu_conf.h
@@ -201,7 +201,8 @@ virCPUDefStealModel(virCPUDef *dst,
                     bool keepVendor);
 
 virCPUDef *
-virCPUDefCopy(const virCPUDef *cpu);
+virCPUDefCopy(const virCPUDef *cpu)
+    ATTRIBUTE_NONNULL(1);
 
 virCPUDef *
 virCPUDefCopyWithoutModel(const virCPUDef *cpu)

diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c
index 30db99cca19521681a188b9980e170c65bb670c6..a33e4da9a97943a8e382534a6c27c0d1ef94f4c7 100644 (file)
--- a/src/cpu/cpu_ppc64.c
+++ b/src/cpu/cpu_ppc64.c
@@ -406,8 +406,12 @@ ppc64Compute(virCPUDef *host,
     size_t i;
 
     /* Ensure existing configurations are handled correctly */
-    if (!(cpu = virCPUDefCopy(other)) ||
-        virCPUppc64ConvertLegacy(cpu) < 0)
+    if (!other)
+        return VIR_CPU_COMPARE_ERROR;
+
+    cpu = virCPUDefCopy(other);
+
+    if (virCPUppc64ConvertLegacy(cpu) < 0)
         return VIR_CPU_COMPARE_ERROR;
 
     if (cpu->arch != VIR_ARCH_NONE) {

diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index 6560b7a5029d330a74d2f9d5aa10542e4d4c6a2e..a8a537cbb6ebfd13a58506e54ad8681d5bdc4143 100644 (file)
--- a/src/cpu/cpu_x86.c
+++ b/src/cpu/cpu_x86.c
@@ -3206,7 +3206,7 @@ static int
 virCPUx86ExpandFeatures(virCPUDef *cpu)
 {
     virCPUx86Map *map;
-    g_autoptr(virCPUDef) expanded = NULL;
+    g_autoptr(virCPUDef) expanded = virCPUDefCopy(cpu);
     g_autoptr(virCPUx86Model) model = NULL;
     bool host = cpu->type == VIR_CPU_TYPE_HOST;
     size_t i;
@@ -3214,9 +3214,6 @@ virCPUx86ExpandFeatures(virCPUDef *cpu)
     if (!(map = virCPUx86GetMap()))
         return -1;
 
-    if (!(expanded = virCPUDefCopy(cpu)))
-        return -1;
-
     virCPUDefFreeFeatures(expanded);
 
     if (!(model = x86ModelFind(map, cpu->model))) {

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 376b2c5458cc68154e3e070a888de4f830d8662a..9cc8d999941d8bd0804443215b9c0e3c0e2ea542 100644 (file)
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -1856,17 +1856,14 @@ virQEMUCapsHostCPUDataCopy(virQEMUCapsHostCPUData *dst,
         !(dst->info = qemuMonitorCPUModelInfoCopy(src->info)))
         return -1;
 
-    if (src->reported &&
-        !(dst->reported = virCPUDefCopy(src->reported)))
-        return -1;
+    if (src->reported)
+        dst->reported = virCPUDefCopy(src->reported);
 
-    if (src->migratable &&
-        !(dst->migratable = virCPUDefCopy(src->migratable)))
-        return -1;
+    if (src->migratable)
+        dst->migratable = virCPUDefCopy(src->migratable);
 
-    if (src->full &&
-        !(dst->full = virCPUDefCopy(src->full)))
-        return -1;
+    if (src->full)
+        dst->full = virCPUDefCopy(src->full);
 
     return 0;
 }
@@ -3886,8 +3883,9 @@ virQEMUCapsInitHostCPUModel(virQEMUCaps *qemuCaps,
         if (!(fullCPU = virQEMUCapsProbeHostCPU(qemuCaps->arch, NULL)))
             goto error;
 
-        if (!(cpuExpanded = virCPUDefCopy(cpu)) ||
-            virCPUExpandFeatures(qemuCaps->arch, cpuExpanded) < 0)
+        cpuExpanded = virCPUDefCopy(cpu);
+
+        if (virCPUExpandFeatures(qemuCaps->arch, cpuExpanded) < 0)
             goto error;
 
         for (i = 0; i < cpuExpanded->nfeatures; i++) {

diff --git a/src/qemu/qemu_migration_cookie.c b/src/qemu/qemu_migration_cookie.c
index e151f33e991c2837150dd26b9803f1cebb3cd280..26d07d1ad450019bf0cc1e3511d4b366f4221791 100644 (file)
--- a/src/qemu/qemu_migration_cookie.c
+++ b/src/qemu/qemu_migration_cookie.c
@@ -542,8 +542,7 @@ qemuMigrationCookieAddCPU(qemuMigrationCookie *mig,
     if (mig->cpu)
         return 0;
 
-    if (!(mig->cpu = virCPUDefCopy(vm->def->cpu)))
-        return -1;
+    mig->cpu = virCPUDefCopy(vm->def->cpu);
 
     if (qemuDomainMakeCPUMigratable(mig->cpu) < 0)
         return -1;

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 942f75b6250130493abc64dc1731504194fcc225..9a612ca443f9bbe417feea3fe24d2613f26e97fd 100644 (file)
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -4464,8 +4464,7 @@ qemuProcessUpdateLiveGuestCPU(virDomainObj *vm,
          !def->cpu->model))
         return 0;
 
-    if (!(orig = virCPUDefCopy(def->cpu)))
-        return -1;
+    orig = virCPUDefCopy(def->cpu);
 
     if ((rc = virCPUUpdateLive(def->os.arch, def->cpu, enabled, disabled)) < 0) {
         return -1;

diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c
index e2bf598aacd70acf0dfac0930528645a64473b9d..672cef9f95501e24d3f93b1b690f88bd0ee97262 100644 (file)
--- a/tests/testutilsqemu.c
+++ b/tests/testutilsqemu.c
@@ -581,12 +581,11 @@ int qemuTestDriverInit(virQEMUDriver *driver)
 
     memset(driver, 0, sizeof(*driver));
 
-    if (!(cpuDefault = virCPUDefCopy(&cpuDefaultData)) ||
-        !(cpuHaswell = virCPUDefCopy(&cpuHaswellData)) ||
-        !(cpuPower8 = virCPUDefCopy(&cpuPower8Data)) ||
-        !(cpuPower9 = virCPUDefCopy(&cpuPower9Data)) ||
-        !(cpuPower10 = virCPUDefCopy(&cpuPower10Data)))
-        return -1;
+    cpuDefault = virCPUDefCopy(&cpuDefaultData);
+    cpuHaswell = virCPUDefCopy(&cpuHaswellData);
+    cpuPower8 = virCPUDefCopy(&cpuPower8Data);
+    cpuPower9 = virCPUDefCopy(&cpuPower9Data);
+    cpuPower10 = virCPUDefCopy(&cpuPower10Data);
 
     if (virMutexInit(&driver->lock) < 0)
         return -1;