]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: spi-cadence: enable SPI_CONTROLLER_MUST_TX
authorJun Guo <jun.guo@cixtech.com>
Thu, 15 Jan 2026 09:19:24 +0000 (17:19 +0800)
committerMark Brown <broonie@kernel.org>
Thu, 15 Jan 2026 14:21:28 +0000 (14:21 +0000)
During an SPI read operation, even if the xspi->txbuf passed to the
cdns_spi_writerinterface is empty, it is still necessary to call
cdns_spi_write(xspi, CDNS_SPI_TXD, txw); otherwise, the read operation
will fail to obtain data correctly due to a lack of clocks.

Fixes: 4e00135b2dd1 ("spi: spi-cadence: supports transmission with bits_per_word of 16 and 32")
Reported-by: Rodrigo Alencar <455.rodrigo.alencar@gmail.com>
Closes: https://lore.kernel.org/all/lbijvnnwsnddonmm5pveqzap6iibxhl4maneq43x4j6w64dev6@u75qhm5cwiob/
Signed-off-by: Jun Guo <jun.guo@cixtech.com>
Link: https://patch.msgid.link/20260115091924.844179-1-jun.guo@cixtech.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-cadence.c

index 47054da630d0f1b73ba4b4ffc0cc383fddeded1a..41b5b58cbfac4c66aab70b52d7a78b97a6e30be8 100644 (file)
@@ -729,6 +729,7 @@ static int cdns_spi_probe(struct platform_device *pdev)
        ctlr->unprepare_transfer_hardware = cdns_unprepare_transfer_hardware;
        ctlr->mode_bits = SPI_CPOL | SPI_CPHA;
        ctlr->bits_per_word_mask = SPI_BPW_MASK(8);
+       ctlr->flags = SPI_CONTROLLER_MUST_TX;
 
        if (of_device_is_compatible(pdev->dev.of_node, "cix,sky1-spi-r1p6"))
                ctlr->bits_per_word_mask |= SPI_BPW_MASK(16) | SPI_BPW_MASK(32);