]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
rpmsg: qcom_glink_native: fix error return code of qcom_glink_rx_data()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Sat, 6 Mar 2021 13:36:24 +0000 (05:36 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 May 2021 08:29:39 +0000 (10:29 +0200)
[ Upstream commit 26594c6bbb60c6bc87e3762a86ceece57d164c66 ]

When idr_find() returns NULL to intent, no error return code of
qcom_glink_rx_data() is assigned.
To fix this bug, ret is assigned with -ENOENT in this case.

Fixes: 64f95f87920d ("rpmsg: glink: Use the local intents when receiving data")
Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Link: https://lore.kernel.org/r/20210306133624.17237-1-baijiaju1990@gmail.com
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/rpmsg/qcom_glink_native.c

index 27a05167c18c3bf80d7bd54622a33a8a749ae96e..4840886532ff75170158ba5c14462fc6e032636a 100644 (file)
@@ -857,6 +857,7 @@ static int qcom_glink_rx_data(struct qcom_glink *glink, size_t avail)
                        dev_err(glink->dev,
                                "no intent found for channel %s intent %d",
                                channel->name, liid);
+                       ret = -ENOENT;
                        goto advance_rx;
                }
        }