]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
selftests: rtnetlink: add macsec and vlan nesting test
authorStanislav Fomichev <sdf@fomichev.me>
Wed, 23 Jul 2025 22:47:15 +0000 (15:47 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 25 Jul 2025 18:03:47 +0000 (11:03 -0700)
Add reproducer for [0] with a dummy device.

0: https://lore.kernel.org/netdev/2aff4342b0f5b1539c02ffd8df4c7e58dd9746e7.camel@nvidia.com/
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Simon Horman <horms@kernel.org>
Signed-off-by: Stanislav Fomichev <sdf@fomichev.me>
Link: https://patch.msgid.link/20250723224715.1341121-2-sdf@fomichev.me
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/rtnetlink.sh

index 441b17947230f19a55930b594757d18b7878d728..7020f988f6598d5e36b233ef4307e5989392c09c 100755 (executable)
@@ -21,6 +21,7 @@ ALL_TESTS="
        kci_test_vrf
        kci_test_encap
        kci_test_macsec
+       kci_test_macsec_vlan
        kci_test_ipsec
        kci_test_ipsec_offload
        kci_test_fdb_get
@@ -572,6 +573,41 @@ kci_test_macsec()
        end_test "PASS: macsec"
 }
 
+# Test __dev_set_rx_mode call from dev_uc_add under addr_list_lock spinlock.
+# Make sure __dev_set_promiscuity is not grabbing (sleeping) netdev instance
+# lock.
+# https://lore.kernel.org/netdev/2aff4342b0f5b1539c02ffd8df4c7e58dd9746e7.camel@nvidia.com/
+kci_test_macsec_vlan()
+{
+       msname="test_macsec1"
+       vlanname="test_vlan1"
+       local ret=0
+       run_cmd_grep "^Usage: ip macsec" ip macsec help
+       if [ $? -ne 0 ]; then
+               end_test "SKIP: macsec: iproute2 too old"
+               return $ksft_skip
+       fi
+       run_cmd ip link add link "$devdummy" "$msname" type macsec port 42 encrypt on
+       if [ $ret -ne 0 ];then
+               end_test "FAIL: can't add macsec interface, skipping test"
+               return 1
+       fi
+
+       run_cmd ip link set dev "$msname" up
+       ip link add link "$msname" name "$vlanname" type vlan id 1
+       ip link set dev "$vlanname" address 00:11:22:33:44:88
+       ip link set dev "$vlanname" up
+       run_cmd ip link del dev "$vlanname"
+       run_cmd ip link del dev "$msname"
+
+       if [ $ret -ne 0 ];then
+               end_test "FAIL: macsec_vlan"
+               return 1
+       fi
+
+       end_test "PASS: macsec_vlan"
+}
+
 #-------------------------------------------------------------------
 # Example commands
 #   ip x s add proto esp src 14.0.0.52 dst 14.0.0.70 \