]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
kconfig: gconf: fix potential memory leak in renderer_edited()
authorMasahiro Yamada <masahiroy@kernel.org>
Tue, 24 Jun 2025 15:04:55 +0000 (00:04 +0900)
committerMasahiro Yamada <masahiroy@kernel.org>
Mon, 30 Jun 2025 04:20:56 +0000 (13:20 +0900)
If gtk_tree_model_get_iter() fails, gtk_tree_path_free() is not called.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
scripts/kconfig/gconf.c

index a3978d3420d1447870e975a189494c6f7273ee64..769f38307f34f68af98f879a4efcc9e8adea1c33 100644 (file)
@@ -745,7 +745,7 @@ static void renderer_edited(GtkCellRendererText * cell,
        struct symbol *sym;
 
        if (!gtk_tree_model_get_iter(model2, &iter, path))
-               return;
+               goto free;
 
        gtk_tree_model_get(model2, &iter, COL_MENU, &menu, -1);
        sym = menu->sym;
@@ -757,6 +757,7 @@ static void renderer_edited(GtkCellRendererText * cell,
 
        update_tree(&rootmenu, NULL);
 
+free:
        gtk_tree_path_free(path);
 }