]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
RDMA/srp: Fix srp_abort()
authorBart Van Assche <bvanassche@acm.org>
Thu, 8 Sep 2022 23:31:39 +0000 (16:31 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Oct 2022 07:57:54 +0000 (09:57 +0200)
[ Upstream commit 6dbe4a8dead84de474483910b02ec9e6a10fc1a9 ]

Fix the code for converting a SCSI command pointer into an SRP request
pointer.

Cc: Xiao Yang <yangx.jy@fujitsu.com>
Fixes: ad215aaea4f9 ("RDMA/srp: Make struct scsi_cmnd and struct srp_request adjacent")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20220908233139.3042628-1-bvanassche@acm.org
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/infiniband/ulp/srp/ib_srp.c

index 3d9c108d73ad81a0ee91950c3e2c36681f322ab1..c3fa65977b3ed339e43e0c0de2c752ae8e23740b 100644 (file)
@@ -2790,7 +2790,7 @@ static int srp_send_tsk_mgmt(struct srp_rdma_ch *ch, u64 req_tag, u64 lun,
 static int srp_abort(struct scsi_cmnd *scmnd)
 {
        struct srp_target_port *target = host_to_target(scmnd->device->host);
-       struct srp_request *req = (struct srp_request *) scmnd->host_scribble;
+       struct srp_request *req = scsi_cmd_priv(scmnd);
        u32 tag;
        u16 ch_idx;
        struct srp_rdma_ch *ch;
@@ -2798,8 +2798,6 @@ static int srp_abort(struct scsi_cmnd *scmnd)
 
        shost_printk(KERN_ERR, target->scsi_host, "SRP abort called\n");
 
-       if (!req)
-               return SUCCESS;
        tag = blk_mq_unique_tag(scsi_cmd_to_rq(scmnd));
        ch_idx = blk_mq_unique_tag_to_hwq(tag);
        if (WARN_ON_ONCE(ch_idx >= target->ch_count))