]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
s390: always declare expoline thunks
authorIlya Leoshkevich <iii@linux.ibm.com>
Mon, 19 May 2025 22:30:04 +0000 (23:30 +0100)
committerAlexei Starovoitov <ast@kernel.org>
Thu, 22 May 2025 15:40:56 +0000 (08:40 -0700)
It would be convenient to use the following pattern in the BPF JIT:

  if (nospec_uses_trampoline())
    emit_call(__s390_indirect_jump_r1);

Unfortunately with CONFIG_EXPOLINE=n the compiler complains about the
missing prototype of __s390_indirect_jump_r1(). One could wrap the
whole "if" statement in an #ifdef, but this clutters the code.

Instead, declare expoline thunk prototypes even when compiling without
expolines. When using the above code structure and compiling without
expolines, references to them are optimized away, and there are no
linker errors.

Acked-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Link: https://lore.kernel.org/r/20250519223646.66382-2-iii@linux.ibm.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
arch/s390/include/asm/nospec-branch.h

index 192835a3e24dcf195e31552e266d37791b537f52..c7c96282f0113025e736b82b45d69db9d7018e4f 100644 (file)
@@ -26,8 +26,6 @@ static inline bool nospec_uses_trampoline(void)
        return __is_defined(CC_USING_EXPOLINE) && !nospec_disable;
 }
 
-#ifdef CONFIG_EXPOLINE_EXTERN
-
 void __s390_indirect_jump_r1(void);
 void __s390_indirect_jump_r2(void);
 void __s390_indirect_jump_r3(void);
@@ -44,8 +42,6 @@ void __s390_indirect_jump_r13(void);
 void __s390_indirect_jump_r14(void);
 void __s390_indirect_jump_r15(void);
 
-#endif
-
 #endif /* __ASSEMBLY__ */
 
 #endif /* _ASM_S390_EXPOLINE_H */