]> git.ipfire.org Git - thirdparty/xtables-addons.git/commitdiff
xt_iface: reduce indent by early return
authorJan Engelhardt <jengelh@medozas.de>
Sun, 24 Oct 2010 14:35:12 +0000 (16:35 +0200)
committerJan Engelhardt <jengelh@medozas.de>
Sun, 24 Oct 2010 14:35:12 +0000 (16:35 +0200)
extensions/xt_iface.c

index 4bf54869cd9e443046c729ea3582e204b348f805..ce0491594cc9069380056caa3803afedc534d8b3 100644 (file)
@@ -53,16 +53,17 @@ static bool xt_iface_mt(const struct sk_buff *skb,
 #else
        dev = dev_get_by_name(info->ifname);
 #endif
-       retval = dev != NULL;
-       if (retval) {
-               for (i = 0; i < ARRAY_SIZE(xt_iface_lookup) && retval; ++i) {
-                       if (info->flags & xt_iface_lookup[i].iface_flag)
-                               retval &= dev->flags & xt_iface_lookup[i].iff_flag;
-                       if (info->invflags & xt_iface_lookup[i].iface_flag)
-                               retval &= !(dev->flags & xt_iface_lookup[i].iff_flag);
-               }
-               dev_put(dev);
+       if (dev == NULL)
+               return false;
+
+       retval = true;
+       for (i = 0; i < ARRAY_SIZE(xt_iface_lookup) && retval; ++i) {
+               if (info->flags & xt_iface_lookup[i].iface_flag)
+                       retval &= dev->flags & xt_iface_lookup[i].iff_flag;
+               if (info->invflags & xt_iface_lookup[i].iface_flag)
+                       retval &= !(dev->flags & xt_iface_lookup[i].iff_flag);
        }
+       dev_put(dev);
        return retval;
 }