]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: dsa: realtek: rtl8365mb: remove ifOutDiscards from rx_packets
authorMieczyslaw Nalewaj <namiltd@yahoo.com>
Tue, 3 Mar 2026 20:25:12 +0000 (17:25 -0300)
committerJakub Kicinski <kuba@kernel.org>
Fri, 6 Mar 2026 02:27:04 +0000 (18:27 -0800)
rx_packets should report the number of frames successfully received:
unicast + multicast + broadcast. Subtracting ifOutDiscards (a TX
counter) is incorrect and can undercount RX packets. RX drops are
already reported via rx_dropped (e.g. etherStatsDropEvents), so
there is no need to adjust rx_packets.

This patch removes the subtraction of ifOutDiscards from rx_packets
in rtl8365mb_stats_update().

Link: https://lore.kernel.org/netdev/878777925.105015.1763423928520@mail.yahoo.com/
Fixes: 4af2950c50c8 ("net: dsa: realtek-smi: add rtl8365mb subdriver for RTL8365MB-VC")
Signed-off-by: Mieczyslaw Nalewaj <namiltd@yahoo.com>
Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Acked-by: Linus Walleij <linusw@kernel.org>
Link: https://patch.msgid.link/20260303-realtek_namiltd_fix2-v1-1-bfa433d3401e@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/realtek/rtl8365mb.c

index f938a3f701cc955b07c45a6eeceed8bb17bc4178..31fa94dac627d6ed3bf8f9a0ff0f17b954c62c0d 100644 (file)
@@ -1480,8 +1480,7 @@ static void rtl8365mb_stats_update(struct realtek_priv *priv, int port)
 
        stats->rx_packets = cnt[RTL8365MB_MIB_ifInUcastPkts] +
                            cnt[RTL8365MB_MIB_ifInMulticastPkts] +
-                           cnt[RTL8365MB_MIB_ifInBroadcastPkts] -
-                           cnt[RTL8365MB_MIB_ifOutDiscards];
+                           cnt[RTL8365MB_MIB_ifInBroadcastPkts];
 
        stats->tx_packets = cnt[RTL8365MB_MIB_ifOutUcastPkts] +
                            cnt[RTL8365MB_MIB_ifOutMulticastPkts] +