net: bridge: use atomic ops to read/change p->flags (III)

Use test_bit(), clear_bit(), set_bit() in:

   net/bridge/br_multicast.c
   net/bridge/br_netlink.c
   net/bridge/br_stp.c
   net/bridge/br_stp_bpdu.c
   net/bridge/br_switchdev.c
   net/bridge/br_vlan_options.c

Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
Link: https://patch.msgid.link/20260611203453.3067462-6-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index c2c93c7404151dcf02e59eb8b868ec3e39dfd5bd..6b3ac473fd228b65d1479963e032a63a9f9210ee 100644 (file)
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -281,7 +281,7 @@ static bool br_port_group_equal(struct net_bridge_port_group *p,
        if (p->key.port != port)
                return false;
 
-       if (!(port->flags & BR_MULTICAST_TO_UNICAST))
+       if (!test_bit(BR_MULTICAST_TO_UNICAST_BIT, &port->flags))
                return true;
 
        return ether_addr_equal(src, p->eth_addr);
@@ -3672,7 +3672,8 @@ br_multicast_leave_group(struct net_bridge_mcast *brmctx,
        if (!mp)
                goto out;
 
-       if (pmctx && (pmctx->port->flags & BR_MULTICAST_FAST_LEAVE)) {
+       if (pmctx &&
+           test_bit(BR_MULTICAST_FAST_LEAVE_BIT, &pmctx->port->flags)) {
                struct net_bridge_port_group __rcu **pp;
 
                for (pp = &mp->ports;

diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
index 2178eb20475c36acc44890cc8384270d376febc3..b2cd4e39326d0634652afee09998b8ad6cef962c 100644 (file)
--- a/net/bridge/br_netlink.c
+++ b/net/bridge/br_netlink.c
@@ -540,7 +540,7 @@ static int br_fill_ifinfo(struct sk_buff *skb,
                else
                        err = br_fill_ifvlaninfo(skb, vg);
 
-               if (port && (port->flags & BR_VLAN_TUNNEL))
+               if (port && test_bit(BR_VLAN_TUNNEL_BIT, &port->flags))
                        err = br_fill_vlan_tunnel_info(skb, vg);
                rcu_read_unlock();
                if (err)

diff --git a/net/bridge/br_stp.c b/net/bridge/br_stp.c
index b33eb085d9b6cb4cd4f3aff2aa4793d027bbc0f8..46919d73d42f98ad92ad0c4ddd2396a0cdd90c02 100644 (file)
--- a/net/bridge/br_stp.c
+++ b/net/bridge/br_stp.c
@@ -39,7 +39,7 @@ void br_set_state(struct net_bridge_port *p, unsigned int state)
        /* Don't change the state of the ports if they are driven by a different
         * protocol.
         */
-       if (p->flags & BR_MRP_AWARE)
+       if (test_bit(BR_MRP_AWARE_BIT, &p->flags))
                return;
 
        p->state = state;
@@ -179,7 +179,7 @@ static void br_root_selection(struct net_bridge *br)
                if (!br_should_become_root_port(p, root_port))
                        continue;
 
-               if (p->flags & BR_ROOT_BLOCK)
+               if (test_bit(BR_ROOT_BLOCK_BIT, &p->flags))
                        br_root_port_block(br, p);
                else
                        root_port = p->port_no;

diff --git a/net/bridge/br_stp_bpdu.c b/net/bridge/br_stp_bpdu.c
index 7895489ac6fe7ca47cf001c0fea267d5dcbd4371..74ec42ba1e7d086cbfde608c93f5fa24d6b4ed7b 100644 (file)
--- a/net/bridge/br_stp_bpdu.c
+++ b/net/bridge/br_stp_bpdu.c
@@ -178,7 +178,7 @@ void br_stp_rcv(const struct stp_proto *proto, struct sk_buff *skb,
        if (!ether_addr_equal(eth_hdr(skb)->h_dest, br->group_addr))
                goto out;
 
-       if (p->flags & BR_BPDU_GUARD) {
+       if (test_bit(BR_BPDU_GUARD_BIT, &p->flags)) {
                br_notice(br, "BPDU received on blocked port %u(%s)\n",
                          (unsigned int) p->port_no, p->dev->name);
                br_stp_disable_port(p);

diff --git a/net/bridge/br_switchdev.c b/net/bridge/br_switchdev.c
index ee3ad9dfbab99597ab06d5e6e008519d4e17fd6a..990c6b38fd397ad364297b130b0f3736ac7b13a7 100644 (file)
--- a/net/bridge/br_switchdev.c
+++ b/net/bridge/br_switchdev.c
@@ -20,7 +20,7 @@ static bool nbp_switchdev_can_offload_tx_fwd(const struct net_bridge_port *p,
        if (br_multicast_igmp_type(skb))
                return false;
 
-       return (p->flags & BR_TX_FWD_OFFLOAD) &&
+       return test_bit(BR_TX_FWD_OFFLOAD_BIT, &p->flags) &&
               (p->hwdom != BR_INPUT_SKB_CB(skb)->src_hwdom);
 }
 
@@ -287,7 +287,7 @@ static int nbp_switchdev_add(struct net_bridge_port *p,
                return err;
 
        if (tx_fwd_offload) {
-               p->flags |= BR_TX_FWD_OFFLOAD;
+               set_bit(BR_TX_FWD_OFFLOAD_BIT, &p->flags);
                static_branch_inc(&br_switchdev_tx_fwd_offload);
        }
 
@@ -307,8 +307,8 @@ static void nbp_switchdev_del(struct net_bridge_port *p)
        if (p->hwdom)
                nbp_switchdev_hwdom_put(p);
 
-       if (p->flags & BR_TX_FWD_OFFLOAD) {
-               p->flags &= ~BR_TX_FWD_OFFLOAD;
+       if (test_bit(BR_TX_FWD_OFFLOAD_BIT, &p->flags)) {
+               clear_bit(BR_TX_FWD_OFFLOAD_BIT, &p->flags);
                static_branch_dec(&br_switchdev_tx_fwd_offload);
        }
 }

diff --git a/net/bridge/br_vlan_options.c b/net/bridge/br_vlan_options.c
index 92af1e558fda886301f167463ddf43f14afd2702..fcc200c3e3da260465f9eb8ab1c8c87e2d3f7588 100644 (file)
--- a/net/bridge/br_vlan_options.c
+++ b/net/bridge/br_vlan_options.c
@@ -172,7 +172,7 @@ static int br_vlan_modify_tunnel(const struct net_bridge_port *p,
                NL_SET_ERR_MSG_MOD(extack, "Can't modify tunnel mapping of non-port vlans");
                return -EINVAL;
        }
-       if (!(p->flags & BR_VLAN_TUNNEL)) {
+       if (!test_bit(BR_VLAN_TUNNEL_BIT, &p->flags)) {
                NL_SET_ERR_MSG_MOD(extack, "Port doesn't have tunnel flag set");
                return -EINVAL;
        }