]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
vsh: cmdEcho: use separate variable for argument
authorJán Tomko <jtomko@redhat.com>
Tue, 10 Aug 2021 15:10:34 +0000 (17:10 +0200)
committerJán Tomko <jtomko@redhat.com>
Wed, 11 Aug 2021 08:52:58 +0000 (10:52 +0200)
Do not use 'arg' which is later used for an allocated string.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
tools/vsh.c

index 3bbaecd2ea4d0e8bd429e12f1d79c2c292a99318..bf32a8dc227d9514fd18dc33d5d4a0f22e414740 100644 (file)
@@ -3199,17 +3199,16 @@ cmdEcho(vshControl *ctl, const vshCmd *cmd)
     while ((opt = vshCommandOptArgv(ctl, cmd, opt))) {
         char *str;
         g_auto(virBuffer) xmlbuf = VIR_BUFFER_INITIALIZER;
-
-        arg = opt->data;
+        const char *curr = opt->data;
 
         if (count)
             virBufferAddChar(&buf, ' ');
 
         if (xml) {
-            virBufferEscapeString(&xmlbuf, "%s", arg);
+            virBufferEscapeString(&xmlbuf, "%s", curr);
             str = virBufferContentAndReset(&xmlbuf);
         } else {
-            str = g_strdup(arg);
+            str = g_strdup(curr);
         }
 
         if (shell)