]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
clk: sprd: div: convert from divider_round_rate() to divider_determine_rate()
authorBrian Masney <bmasney@redhat.com>
Thu, 8 Jan 2026 21:16:36 +0000 (16:16 -0500)
committerBrian Masney <bmasney@redhat.com>
Thu, 22 Jan 2026 15:48:26 +0000 (10:48 -0500)
The divider_round_rate() function is now deprecated, so let's migrate
to divider_determine_rate() instead so that this deprecated API can be
removed.

Note that when the main function itself was migrated to use
determine_rate, this was mistakenly converted to:

    req->rate = divider_round_rate(...)

This is invalid in the case when an error occurs since it can set the
rate to a negative value.

Fixes: deb4740a5ff8 ("clk: sprd: div: convert from round_rate() to determine_rate()")
Signed-off-by: Brian Masney <bmasney@redhat.com>
drivers/clk/sprd/div.c

index 013423881968002d29c4e9536e7cd7b944779196..cd57163a7204c0b21ac081bfda3ab57cab28fbc4 100644 (file)
@@ -14,11 +14,7 @@ static int sprd_div_determine_rate(struct clk_hw *hw,
 {
        struct sprd_div *cd = hw_to_sprd_div(hw);
 
-       req->rate = divider_round_rate(&cd->common.hw, req->rate,
-                                      &req->best_parent_rate,
-                                      NULL, cd->div.width, 0);
-
-       return 0;
+       return divider_determine_rate(&cd->common.hw, req, NULL, cd->div.width, 0);
 }
 
 unsigned long sprd_div_helper_recalc_rate(struct sprd_clk_common *common,