[#2131] Addressed comment

diff --git a/src/bin/d2/nc_add.cc b/src/bin/d2/nc_add.cc
index 2d47d57b8b5c53a86741bae29b2d9a010d070819..0d517cb4d52ffe549d4f72aef45fbc521e2b3b60 100644 (file)
--- a/src/bin/d2/nc_add.cc
+++ b/src/bin/d2/nc_add.cc
@@ -175,12 +175,11 @@ NameAddTransaction::addingFwdAddrsHandler() {
         // Clear the update attempts count on initial transition.
         clearUpdateAttempts();
     }
-    // No reuse of the request on retries.
-    clearDnsUpdateRequest();
 
     switch(getNextEvent()) {
     case SERVER_SELECTED_EVT:
         try {
+            clearDnsUpdateRequest();
             buildAddFwdAddressRequest();
         } catch (const std::exception& ex) {
             // While unlikely, the build might fail if we have invalid
@@ -288,13 +287,12 @@ NameAddTransaction::replacingFwdAddrsHandler() {
         // Clear the update attempts count on initial transition.
         clearUpdateAttempts();
     }
-    // No reuse of the request on retries.
-    clearDnsUpdateRequest();
 
     switch(getNextEvent()) {
     case FQDN_IN_USE_EVT:
     case SERVER_SELECTED_EVT:
         try {
+            clearDnsUpdateRequest();
             buildReplaceFwdAddressRequest();
         } catch (const std::exception& ex) {
             // While unlikely, the build might fail if we have invalid
@@ -438,12 +436,11 @@ NameAddTransaction::replacingRevPtrsHandler() {
         // Clear the update attempts count on initial transition.
         clearUpdateAttempts();
     }
-    // No reuse of the request on retries.
-    clearDnsUpdateRequest();
 
     switch(getNextEvent()) {
     case SERVER_SELECTED_EVT:
         try {
+            clearDnsUpdateRequest();
             buildReplaceRevPtrsRequest();
         } catch (const std::exception& ex) {
             // While unlikely, the build might fail if we have invalid

diff --git a/src/bin/d2/nc_remove.cc b/src/bin/d2/nc_remove.cc
index 6cc468fe69dc171804db132d7882b7e7e40a933f..cd9c6794bf67664a5c611e91448947a93bf15cbc 100644 (file)
--- a/src/bin/d2/nc_remove.cc
+++ b/src/bin/d2/nc_remove.cc
@@ -179,12 +179,11 @@ NameRemoveTransaction::removingFwdAddrsHandler() {
         // Clear the update attempts count on initial transition.
         clearUpdateAttempts();
     }
-    // No reuse of the request on retries.
-    clearDnsUpdateRequest();
 
     switch(getNextEvent()) {
     case SERVER_SELECTED_EVT:
         try {
+            clearDnsUpdateRequest();
             buildRemoveFwdAddressRequest();
         } catch (const std::exception& ex) {
             // While unlikely, the build might fail if we have invalid
@@ -287,13 +286,12 @@ NameRemoveTransaction::removingFwdRRsHandler() {
         // Clear the update attempts count on initial transition.
         clearUpdateAttempts();
     }
-    // No reuse of the request on retries.
-    clearDnsUpdateRequest();
 
     switch(getNextEvent()) {
     case UPDATE_OK_EVT:
     case SERVER_SELECTED_EVT:
         try {
+            clearDnsUpdateRequest();
             buildRemoveFwdRRsRequest();
         } catch (const std::exception& ex) {
             // While unlikely, the build might fail if we have invalid
@@ -445,12 +443,11 @@ NameRemoveTransaction::removingRevPtrsHandler() {
         // Clear the update attempts count on initial transition.
         clearUpdateAttempts();
     }
-    // No reuse of the request on retries.
-    clearDnsUpdateRequest();
 
     switch(getNextEvent()) {
     case SERVER_SELECTED_EVT:
         try {
+            clearDnsUpdateRequest();
             buildRemoveRevPtrsRequest();
         } catch (const std::exception& ex) {
             // While unlikely, the build might fail if we have invalid

diff --git a/src/bin/d2/simple_add.cc b/src/bin/d2/simple_add.cc
index dcf0415c4b27e0ae5327ad2b309b6a1e90c323f1..c1814c77b4d10df9bb9ae453ce0b66e67e70a216 100644 (file)
--- a/src/bin/d2/simple_add.cc
+++ b/src/bin/d2/simple_add.cc
@@ -170,12 +170,11 @@ SimpleAddTransaction::replacingFwdAddrsHandler() {
         // Clear the update attempts count on initial transition.
         clearUpdateAttempts();
     }
-    // No reuse of the request on retries.
-    clearDnsUpdateRequest();
 
     switch(getNextEvent()) {
     case SERVER_SELECTED_EVT:
         try {
+            clearDnsUpdateRequest();
             buildReplaceFwdAddressRequest();
         } catch (const std::exception& ex) {
             // While unlikely, the build might fail if we have invalid
@@ -307,12 +306,11 @@ SimpleAddTransaction::replacingRevPtrsHandler() {
         // Clear the update attempts count on initial transition.
         clearUpdateAttempts();
     }
-    // No reuse of the request on retries.
-    clearDnsUpdateRequest();
 
     switch(getNextEvent()) {
     case SERVER_SELECTED_EVT:
         try {
+            clearDnsUpdateRequest();
             buildReplaceRevPtrsRequest();
         } catch (const std::exception& ex) {
             // While unlikely, the build might fail if we have invalid

diff --git a/src/bin/d2/simple_remove.cc b/src/bin/d2/simple_remove.cc
index 823628e47893eab2ce20bf79e5d672ec3f58137e..457afe712527c1868f1cfb35faa191e6b1d3dc41 100644 (file)
--- a/src/bin/d2/simple_remove.cc
+++ b/src/bin/d2/simple_remove.cc
@@ -173,13 +173,12 @@ SimpleRemoveTransaction::removingFwdRRsHandler() {
         // Clear the update attempts count on initial transition.
         clearUpdateAttempts();
     }
-    // No reuse of the request on retries.
-    clearDnsUpdateRequest();
 
     switch(getNextEvent()) {
     case UPDATE_OK_EVT:
     case SERVER_SELECTED_EVT:
         try {
+            clearDnsUpdateRequest();
             buildRemoveFwdRRsRequest();
         } catch (const std::exception& ex) {
             // While unlikely, the build might fail if we have invalid
@@ -320,12 +319,11 @@ SimpleRemoveTransaction::removingRevPtrsHandler() {
         // Clear the update attempts count on initial transition.
         clearUpdateAttempts();
     }
-    // No reuse of the request on retries.
-    clearDnsUpdateRequest();
 
     switch(getNextEvent()) {
     case SERVER_SELECTED_EVT:
         try {
+            clearDnsUpdateRequest();
             buildRemoveRevPtrsRequest();
         } catch (const std::exception& ex) {
             // While unlikely, the build might fail if we have invalid