src: drop obsolete checks for virDomainConfigFile failure

This cannot ever return NULL

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
index 2bd1e4c3878c103cdfbdc075ed1b97533ca5a685..8f97ac032c14532c48d218911614b2cd0163e938 100644 (file)
--- a/src/bhyve/bhyve_driver.c
+++ b/src/bhyve/bhyve_driver.c
@@ -364,10 +364,8 @@ bhyveDomainSetAutostart(virDomainPtr domain, int autostart)
     autostart = (autostart != 0);
 
     if (vm->autostart != autostart) {
-        if ((configFile = virDomainConfigFile(BHYVE_CONFIG_DIR, vm->def->name)) == NULL)
-            goto cleanup;
-        if ((autostartLink = virDomainConfigFile(BHYVE_AUTOSTART_DIR, vm->def->name)) == NULL)
-            goto cleanup;
+        configFile = virDomainConfigFile(BHYVE_CONFIG_DIR, vm->def->name);
+        autostartLink = virDomainConfigFile(BHYVE_AUTOSTART_DIR, vm->def->name);
 
         if (autostart) {
             if (g_mkdir_with_parents(BHYVE_AUTOSTART_DIR, 0777) < 0) {

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 4ad8289b894ff955b2b0ac77277be97d435c7f5e..3c19c89af916df7612e6e458ab0f48058540147f 100644 (file)
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -29002,8 +29002,7 @@ virDomainDefSaveXML(virDomainDef *def,
     if (!configDir)
         return 0;
 
-    if ((configFile = virDomainConfigFile(configDir, def->name)) == NULL)
-        return -1;
+    configFile = virDomainConfigFile(configDir, def->name);
 
     if (g_mkdir_with_parents(configDir, 0777) < 0) {
         virReportSystemError(errno,
@@ -29060,11 +29059,8 @@ virDomainDeleteConfig(const char *configDir,
     g_autofree char *configFile = NULL;
     g_autofree char *autostartLink = NULL;
 
-    if ((configFile = virDomainConfigFile(configDir, dom->def->name)) == NULL)
-        return -1;
-    if ((autostartLink = virDomainConfigFile(autostartDir,
-                                             dom->def->name)) == NULL)
-        return -1;
+    configFile = virDomainConfigFile(configDir, dom->def->name);
+    autostartLink = virDomainConfigFile(autostartDir, dom->def->name);
 
     /* Not fatal if this doesn't work */
     unlink(autostartLink);

diff --git a/src/conf/virdomainobjlist.c b/src/conf/virdomainobjlist.c
index 166bbc5cfd57e46c7c386b6ebc0bcf23ba204a3b..72207450c5e7b3f313b2190c974b0bd6053bd6d4 100644 (file)
--- a/src/conf/virdomainobjlist.c
+++ b/src/conf/virdomainobjlist.c
@@ -492,16 +492,14 @@ virDomainObjListLoadConfig(virDomainObjList *doms,
     int autostart;
     g_autoptr(virDomainDef) oldDef = NULL;
 
-    if ((configFile = virDomainConfigFile(configDir, name)) == NULL)
-        return NULL;
+    configFile = virDomainConfigFile(configDir, name);
     if (!(def = virDomainDefParseFile(configFile, xmlopt, NULL,
                                       VIR_DOMAIN_DEF_PARSE_INACTIVE |
                                       VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE |
                                       VIR_DOMAIN_DEF_PARSE_ALLOW_POST_PARSE_FAIL)))
         return NULL;
 
-    if ((autostartLink = virDomainConfigFile(autostartDir, name)) == NULL)
-        return NULL;
+    autostartLink = virDomainConfigFile(autostartDir, name);
 
     autostart = virFileLinkPointsTo(autostartLink, configFile);
 
@@ -529,8 +527,7 @@ virDomainObjListLoadStatus(virDomainObjList *doms,
     virDomainObj *obj = NULL;
     char uuidstr[VIR_UUID_STRING_BUFLEN];
 
-    if ((statusFile = virDomainConfigFile(statusDir, name)) == NULL)
-        goto error;
+    statusFile = virDomainConfigFile(statusDir, name);
 
     if (!(obj = virDomainObjParseFile(statusFile, xmlopt,
                                       VIR_DOMAIN_DEF_PARSE_STATUS |

diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index 2c0cf75562d4a846235fbcdd49bc999aad33b906..494b1ad9bcb960a36f158ca62e7aadb667e9e8b8 100644 (file)
--- a/src/libxl/libxl_driver.c
+++ b/src/libxl/libxl_driver.c
@@ -4656,10 +4656,8 @@ libxlDomainSetAutostart(virDomainPtr dom, int autostart)
     autostart = (autostart != 0);
 
     if (vm->autostart != autostart) {
-        if (!(configFile = virDomainConfigFile(cfg->configDir, vm->def->name)))
-            goto endjob;
-        if (!(autostartLink = virDomainConfigFile(cfg->autostartDir, vm->def->name)))
-            goto endjob;
+        configFile = virDomainConfigFile(cfg->configDir, vm->def->name);
+        autostartLink = virDomainConfigFile(cfg->autostartDir, vm->def->name);
 
         if (autostart) {
             if (g_mkdir_with_parents(cfg->autostartDir, 0777) < 0) {

diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c
index 7b432a1160de6dec2b8f0eea97c20ee318339941..fb7f8e0bc24ba8257d71d985d87ed5706496bf17 100644 (file)
--- a/src/lxc/lxc_controller.c
+++ b/src/lxc/lxc_controller.c
@@ -196,9 +196,7 @@ static virLXCController *virLXCControllerNew(const char *name)
     if (!(driver = virLXCControllerDriverNew()))
         goto error;
 
-    if ((configFile = virDomainConfigFile(LXC_STATE_DIR,
-                                          ctrl->name)) == NULL)
-        goto error;
+    configFile = virDomainConfigFile(LXC_STATE_DIR, ctrl->name);
 
     if ((ctrl->vm = virDomainObjParseFile(configFile,
                                           driver->xmlopt,

diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
index cc4b2a05d6e53b635a6e83777798a6774aae5b26..4740aeed528eaf800f7e61a585b1ac6244a63644 100644 (file)
--- a/src/lxc/lxc_driver.c
+++ b/src/lxc/lxc_driver.c
@@ -2439,14 +2439,8 @@ static int lxcDomainSetAutostart(virDomainPtr dom,
         goto endjob;
     }
 
-    configFile = virDomainConfigFile(cfg->configDir,
-                                     vm->def->name);
-    if (configFile == NULL)
-        goto endjob;
-    autostartLink = virDomainConfigFile(cfg->autostartDir,
-                                        vm->def->name);
-    if (autostartLink == NULL)
-        goto endjob;
+    configFile = virDomainConfigFile(cfg->configDir, vm->def->name);
+    autostartLink = virDomainConfigFile(cfg->autostartDir, vm->def->name);
 
     if (autostart) {
         if (g_mkdir_with_parents(cfg->autostartDir, 0777) < 0) {

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 388aa2b34e1c45e08412ccbefec08103ca63669e..d2eddbd9aebd42150a6c2bab702560d48a755254 100644 (file)
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -7790,12 +7790,8 @@ static int qemuDomainSetAutostart(virDomainPtr dom,
         if (virDomainObjBeginJob(vm, VIR_JOB_MODIFY) < 0)
             goto cleanup;
 
-        if (!(configFile = virDomainConfigFile(cfg->configDir, vm->def->name)))
-            goto endjob;
-
-        if (!(autostartLink = virDomainConfigFile(cfg->autostartDir,
-                                                  vm->def->name)))
-            goto endjob;
+        configFile = virDomainConfigFile(cfg->configDir, vm->def->name);
+        autostartLink = virDomainConfigFile(cfg->autostartDir, vm->def->name);
 
         if (autostart) {
             if (g_mkdir_with_parents(cfg->autostartDir, 0777) < 0) {
@@ -18345,21 +18341,15 @@ qemuDomainRenameCallback(virDomainObj *vm,
 
     new_dom_name = g_strdup(new_name);
 
-    if (!(new_dom_cfg_file = virDomainConfigFile(cfg->configDir,
-                                                 new_dom_name)) ||
-        !(old_dom_cfg_file = virDomainConfigFile(cfg->configDir,
-                                                 vm->def->name)))
-        return -1;
+    new_dom_cfg_file = virDomainConfigFile(cfg->configDir, new_dom_name);
+    old_dom_cfg_file = virDomainConfigFile(cfg->configDir, vm->def->name);
 
     if (qemuDomainNamePathsCleanup(cfg, new_name, false) < 0)
         goto cleanup;
 
     if (vm->autostart) {
-        if (!(new_dom_autostart_link = virDomainConfigFile(cfg->autostartDir,
-                                                          new_dom_name)) ||
-            !(old_dom_autostart_link = virDomainConfigFile(cfg->autostartDir,
-                                                          vm->def->name)))
-            return -1;
+        new_dom_autostart_link = virDomainConfigFile(cfg->autostartDir, new_dom_name);
+        old_dom_autostart_link = virDomainConfigFile(cfg->autostartDir, vm->def->name);
 
         if (symlink(new_dom_cfg_file, new_dom_autostart_link) < 0) {
             virReportSystemError(errno,