]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virNWFilterBuildAll: Automatically free temporary GHashTable
authorPeter Krempa <pkrempa@redhat.com>
Tue, 30 Nov 2021 10:35:42 +0000 (11:35 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 1 Dec 2021 12:53:11 +0000 (13:53 +0100)
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
src/nwfilter/nwfilter_gentech_driver.c

index 55c7571ea5d8a912721e25e376749d52f9737299..ea1f4f409257f613f079a9f3bf34282eb33d8ee0 100644 (file)
@@ -979,7 +979,8 @@ virNWFilterBuildAll(virNWFilterDriverState *driver,
     VIR_DEBUG("Build all filters newFilters=%d", newFilters);
 
     if (newFilters) {
-        data.skipInterfaces = virHashNew(NULL);
+        g_autoptr(GHashTable) skipInterfaces = virHashNew(NULL);
+        data.skipInterfaces = skipInterfaces;
 
         data.step = STEP_APPLY_NEW;
         if (virNWFilterBindingObjListForEach(driver->bindings,
@@ -998,8 +999,6 @@ virNWFilterBuildAll(virNWFilterDriverState *driver,
                                              virNWFilterBuildIter,
                                              &data);
         }
-
-        virHashFree(data.skipInterfaces);
     } else {
         data.step = STEP_APPLY_CURRENT;
         if (virNWFilterBindingObjListForEach(driver->bindings,