tmpl_from_attr_substr ret = 0 also indicates an error

diff --git a/src/modules/rlm_expr/rlm_expr.c b/src/modules/rlm_expr/rlm_expr.c
index bcaa3be038e4ffb25b8b9c37c1cededac89673e7..7b476b9a9f598daef2df51788041f69ac91e2858 100644 (file)
--- a/src/modules/rlm_expr/rlm_expr.c
+++ b/src/modules/rlm_expr/rlm_expr.c
@@ -231,7 +231,7 @@ static bool get_number(REQUEST *request, char const **string, int64_t *answer)
                p += 1;
 
                slen = tmpl_from_attr_substr(&vpt, p, REQUEST_CURRENT, PAIR_LIST_REQUEST, false, false);
-               if (slen < 0) {
+               if (slen <= 0) {
                        REDEBUG("Failed parsing attribute name '%s': %s", p, fr_strerror());
                        return false;
                }