lib/relocator: Initialize local relocator subchunk struct to all zeros

The way the code is written the tofree variable would never be passed to
the free_subchunk() function uninitialized. Coverity cannot determine
this and flags the situation as "Using uninitialized value...". The fix
is just to initialize the local struct.

Fixes: CID 314016
Signed-off-by: Ross Philipson <ross.philipson@oracle.com>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Tested-by: Alec Brown <alec.r.brown@oracle.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

diff --git a/grub-core/lib/relocator.c b/grub-core/lib/relocator.c
index 68ef1289aa86b1d217d3a5b5b65f64f103d2033a..bfcc70dac3cce58de71d368e090370b5189b22f1 100644 (file)
--- a/grub-core/lib/relocator.c
+++ b/grub-core/lib/relocator.c
@@ -989,7 +989,7 @@ malloc_in_range (struct grub_relocator *rel,
        if (j != 0 && events[j - 1].pos != events[j].pos)
          {
            grub_addr_t alloc_start, alloc_end;
-           struct grub_relocator_subchunk tofree;
+           struct grub_relocator_subchunk tofree = {0};
            struct grub_relocator_subchunk *curschu = &tofree;
            if (!oom)
              curschu = &res->subchunks[cural];