]> git.ipfire.org Git - thirdparty/libcgroup.git/commitdiff
api.c: Fix strncpy() truncation warning
authorTom Hromatka <tom.hromatka@oracle.com>
Tue, 27 Apr 2021 16:35:46 +0000 (16:35 +0000)
committerTom Hromatka <tom.hromatka@oracle.com>
Tue, 27 Apr 2021 16:35:46 +0000 (16:35 +0000)
Fix the following strncpy() string truncation warning:

In function ‘strncpy’,
    inlined from ‘cgroup_parse_rules_file’ at api.c:814:3:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: warning: ‘__builtin_strncpy’ output may be truncated copying 4095 bytes from a string of length 4095 [-Wstringop-truncation]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
src/api.c

index 4e6e3b9e95451a7ce6fde02e95aed18dd26fa0e4..51c4779eaf0f718cbf1a629a2965f29881b9f508 100644 (file)
--- a/src/api.c
+++ b/src/api.c
@@ -813,6 +813,7 @@ static int cgroup_parse_rules_file(char *filename, bool cache, uid_t muid,
                }
                strncpy(newrule->destination, destination,
                        sizeof(newrule->destination) - 1);
+               newrule->destination[sizeof(newrule->destination) - 1] = '\0';
 
                if (has_options) {
                        ret = cgroup_parse_rules_options(options, newrule);