]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: accel: adxl345: simplify measure enable
authorLothar Rubusch <l.rubusch@gmail.com>
Tue, 10 Jun 2025 21:59:25 +0000 (21:59 +0000)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Thu, 26 Jun 2025 18:32:55 +0000 (19:32 +0100)
Simplify the function to enable or disable measurement. Replace the
separate decision logic and call to regmap_update_bits() by a single
call to regmap_assign_bits() taking a boolean argument directly.

This is a refactoring change and should not impact functionality.

Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
Link: https://patch.msgid.link/20250610215933.84795-4-l.rubusch@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/accel/adxl345.h
drivers/iio/accel/adxl345_core.c

index 6c1f96406136807d2b82ad97abf9103d2036394c..9385affdefe3084f1deeef267eaaa2e3259ab919 100644 (file)
@@ -73,7 +73,6 @@
 #define ADXL345_BW_LOW_POWER           BIT(4)
 #define ADXL345_BASE_RATE_NANO_HZ      97656250LL
 
-#define ADXL345_POWER_CTL_STANDBY      0x00
 #define ADXL345_POWER_CTL_WAKEUP       GENMASK(1, 0)
 #define ADXL345_POWER_CTL_SLEEP        BIT(2)
 #define ADXL345_POWER_CTL_MEASURE      BIT(3)
index 00c11402ef3a69807431c6dc37d883ca2a00cc04..e7c01bb154bfa98b6c0d205bae3906c7901bb1b9 100644 (file)
@@ -233,9 +233,8 @@ EXPORT_SYMBOL_NS_GPL(adxl345_is_volatile_reg, "IIO_ADXL345");
  */
 static int adxl345_set_measure_en(struct adxl345_state *st, bool en)
 {
-       unsigned int val = en ? ADXL345_POWER_CTL_MEASURE : ADXL345_POWER_CTL_STANDBY;
-
-       return regmap_write(st->regmap, ADXL345_REG_POWER_CTL, val);
+       return regmap_assign_bits(st->regmap, ADXL345_REG_POWER_CTL,
+                                 ADXL345_POWER_CTL_MEASURE, en);
 }
 
 /* tap */