]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
gpio: tb10x: fix OF_GPIO dependency
authorArnd Bergmann <arnd@arndb.de>
Fri, 5 Dec 2025 09:54:09 +0000 (10:54 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Dec 2025 13:03:37 +0000 (14:03 +0100)
[ Upstream commit dd44d4d0c55a4ecf5eabf7856f96ed47e0684780 ]

Selecting OF_GPIO is generally not allowed, it always gets enabled
when both GPIOLIB and OF are turned on.

The tb10x driver now warns about this after it was enabled for
compile-testing:

WARNING: unmet direct dependencies detected for OF_GPIO
  Depends on [n]: GPIOLIB [=y] && OF [=n] && HAS_IOMEM [=y]
  Selected by [y]:
  - GPIO_TB10X [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] && (ARC_PLAT_TB10X || COMPILE_TEST [=y])

OF_GPIO is not required for compile-testing and is already enabled
when the driver is usable, so just drop the 'select' line.

Fixes: 682fbb18e14c ("gpio: tb10x: allow building the module with COMPILE_TEST=y")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20251205095429.1291866-1-arnd@kernel.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpio/Kconfig

index 7ee3afbc2b05da4d7470e609a0311ecc38727b00..e053524c5e35f1e0ac1527e8616dfd8a6221b103 100644 (file)
@@ -738,7 +738,6 @@ config GPIO_TB10X
        depends on ARC_PLAT_TB10X || COMPILE_TEST
        select GPIO_GENERIC
        select GENERIC_IRQ_CHIP
-       select OF_GPIO
 
 config GPIO_TEGRA
        tristate "NVIDIA Tegra GPIO support"