]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
detect/tls.certs: improve buffer init logic
authorVictor Julien <vjulien@oisf.net>
Sat, 28 Jan 2023 10:40:53 +0000 (11:40 +0100)
committerVictor Julien <vjulien@oisf.net>
Sat, 28 Jan 2023 11:46:41 +0000 (12:46 +0100)
src/detect-tls-certs.c

index c4088222c8ce74f3d004968ad5de34e59b74a3ad..21fb5c8baa44e0040c237103f72b32263bada2c6 100644 (file)
@@ -143,8 +143,8 @@ static InspectionBuffer *TlsCertsGetData(DetectEngineThreadCtx *det_ctx,
 
     InspectionBuffer *buffer =
             InspectionBufferMultipleForListGet(det_ctx, list_id, cbdata->local_id);
-    if (buffer == NULL)
-        return NULL;
+    if (buffer == NULL || buffer->initialized)
+        return buffer;
 
     const SSLState *ssl_state = (SSLState *)f->alstate;
     const SSLStateConnp *connp;
@@ -204,7 +204,7 @@ static uint8_t DetectEngineInspectTlsCerts(DetectEngineCtx *de_ctx, DetectEngine
             return DETECT_ENGINE_INSPECT_SIG_MATCH;
         }
 
-       cbdata.local_id++;
+        cbdata.local_id++;
     }
 
     return DETECT_ENGINE_INSPECT_SIG_NO_MATCH;