]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
tpm: Convert warn to dbg in tpm2_start_auth_session()
authorJonathan McDowell <noodles@meta.com>
Fri, 7 Mar 2025 10:56:44 +0000 (10:56 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 May 2025 09:12:25 +0000 (11:12 +0200)
[ Upstream commit 6359691b4fbcaf3ed86f53043a1f7c6cc54c09be ]

TPM2 sessions have been flushed lazily since commit df745e25098dc ("tpm:
Lazily flush the auth session").  If /dev/tpm{rm}0 is not accessed
in-between two in-kernel calls, it is possible that a TPM2 session is
re-started before the previous one has been completed.

This causes a spurios warning in a legit run-time condition, which is also
correctly addressed with a fast return path:

[    2.944047] tpm tpm0: auth session is active

Address the issue by changing dev_warn_once() call to a dev_dbg_once()
call.

[jarkko: Rewrote the commit message, and instead of dropping converted
 to a debug message.]
Signed-off-by: Jonathan McDowell <noodles@meta.com>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/char/tpm/tpm2-sessions.c

index a894dbc40e43b3e47581ba7fc22d93da93687b8c..7b5049b3d476ef9a91ffa60be73001a498437954 100644 (file)
@@ -974,7 +974,7 @@ int tpm2_start_auth_session(struct tpm_chip *chip)
        int rc;
 
        if (chip->auth) {
-               dev_warn_once(&chip->dev, "auth session is active\n");
+               dev_dbg_once(&chip->dev, "auth session is active\n");
                return 0;
        }